Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh_3 deprecated mesh domains removed in CGAL 6.0 Beta 1 #8311

Closed
joachim-reichel opened this issue Jun 25, 2024 · 5 comments
Closed

Mesh_3 deprecated mesh domains removed in CGAL 6.0 Beta 1 #8311

joachim-reichel opened this issue Jun 25, 2024 · 5 comments

Comments

@joachim-reichel
Copy link
Member

joachim-reichel commented Jun 25, 2024

Compiling pygalmesh from Debian unstable against CGAL 6.0 Beta 1 fails since <CGAL/Implicit_mesh_domain_3.h> is missing. Please check whether it is possible to include a legacy header including the replacement headers with a suitable deprecation message. Otherwise, it might be a good idea to describe in the release notes how to modify the affected code.

Compiling octave-iso2mesh from Debian unstable against CGAL 6.0 Beta 1 fails since <CGAL/Labeled_image_mesh_domain_3.h> is missing. Please check whether it is possible to include a legacy header including the replacement headers with a suitable deprecation message. Otherwise, it might be a good idea to describe in the release notes how to modify the affected code.

@MaelRL MaelRL added this to the 6.0 milestone Jun 25, 2024
@MaelRL
Copy link
Member

MaelRL commented Jun 25, 2024

Here is the commit removing the three deprecated (since 4.13) labeled mesh domains: b3fe07a (#7445)

@MaelRL MaelRL changed the title <CGAL/Labeled_image_mesh_domain_3.h> missing in CGAL 6.0 Beta 1 Mesh_3 deprecated mesh domains removed in CGAL 6.0 Beta 1 Jun 25, 2024
@afabri
Copy link
Member

afabri commented Aug 6, 2024

Hello @joachim-reichel,
As pointed out by @MaelRL these files are deprecated for a while now and had a deprecation warning. Changing the major release number seems a good time to clean up and remove. The downstream projects have to upgrade. Are they aware of it? Do we have to file an issue in the respective projects? What do you consider as best practice?

@joachim-reichel
Copy link
Member Author

Since I didn't know the downstream projects and just tried to build them I wasn't aware that there were already deprecation warnings with CGAL 5.x. All projects that I pointed out in the thread on cgal-develop have now patches filed (some merged/released, others still unmerged/unreleased). So I think we are good as far as reverse dependencies in the Debian repository are concerned.

@sloriot
Copy link
Member

sloriot commented Aug 13, 2024

Should be fixed by fangq/iso2mesh#79

@sloriot
Copy link
Member

sloriot commented Aug 19, 2024

The PR has been merged, I'm closing the issue.

@sloriot sloriot closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants