Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delaunay-based range_search improvements #8465

Open
mglisse opened this issue Sep 4, 2024 · 0 comments
Open

Delaunay-based range_search improvements #8465

mglisse opened this issue Sep 4, 2024 · 0 comments

Comments

@mglisse
Copy link
Member

mglisse commented Sep 4, 2024

Issue Details

Redundancy

Point_set_2.h and range_search_delaunay_2.h seem to contain very redundant code (though they have diverged a bit), compare the codes starting at

if (number_of_vertices() == 0) return res;

if (delau.number_of_vertices() == 0) return res;

Unnecessary mutation

In order to find the points in a disk, the code inserts the center in the triangulation, then walks on the graph, and finally removes the center from the triangulation. We have functions to compute the conflict zone of a point without actually inserting it, I believe they should be sufficient to seed the graph walk.

Dimension

This is currently implemented for Triangulation_2 and Triangulation_d, but not Triangulation_3 or Triangulation.

Environment

  • CGAL version: master 2024-09-04
@mglisse mglisse changed the title Delaunay-base range_search improvements Delaunay-based range_search improvements Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant