Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supplychain module: Wrong currency of WIOD 16 table #113

Open
mastaia opened this issue Feb 21, 2024 · 3 comments
Open

supplychain module: Wrong currency of WIOD 16 table #113

mastaia opened this issue Feb 21, 2024 · 3 comments
Assignees

Comments

@mastaia
Copy link

mastaia commented Feb 21, 2024

In the module:
https://github.com/CLIMADA-project/climada_petals/blob/develop/climada_petals/engine/supplychain.py

On line 304, the mriot unit is assigned in M.EUR.

According to the official data download https://www.rug.nl/ggdc/valuechain/wiod/ and opening the excel table, the unit must be in M.USD
image

@peanutfun
Copy link
Member

Thanks for the report. @aleeciu can you confirm this and maybe come up with a fix?

@mastaia mastaia changed the title supplychain module: Wrong current of WIOD 16 table supplychain module: Wrong currency of WIOD 16 table Feb 21, 2024
@aleeciu
Copy link
Collaborator

aleeciu commented Feb 21, 2024

Yes, that's an error - thanks for spotting. It should not really affect any other piece of the code though, it's really a results' interpretation issue.

It will be fixed in #81.

@mastaia
Copy link
Author

mastaia commented Feb 21, 2024

Agree, it will not affect the results, but just the interpretation.
Thanks a lot.

@spjuhel spjuhel self-assigned this Apr 15, 2024
spjuhel pushed a commit that referenced this issue Apr 17, 2024
- Changed WIOD unit to M.USD
spjuhel pushed a commit that referenced this issue Apr 17, 2024
* ``v`` to ``va`` in functions and variables for better clarity
* B matrix computation taken from ``pymrio``
* calc_G added, instead of using calc_L (it makes sense for documentation purpose)
* Using transpose of G, to keep dimensions the same as with leontief
* added tests for all iomath functions
* Added "M.USD" to possible unit (see #113)
* changed default rebuild tau to 365 to better reflect literature
* Fixed possible problem if final demand category index is not given to
  ``parse_mriot_from_df``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants