-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supplychain module: Wrong currency of WIOD 16 table #113
Comments
Thanks for the report. @aleeciu can you confirm this and maybe come up with a fix? |
Yes, that's an error - thanks for spotting. It should not really affect any other piece of the code though, it's really a results' interpretation issue. It will be fixed in #81. |
15 tasks
Agree, it will not affect the results, but just the interpretation. |
spjuhel
pushed a commit
that referenced
this issue
Apr 17, 2024
* ``v`` to ``va`` in functions and variables for better clarity * B matrix computation taken from ``pymrio`` * calc_G added, instead of using calc_L (it makes sense for documentation purpose) * Using transpose of G, to keep dimensions the same as with leontief * added tests for all iomath functions * Added "M.USD" to possible unit (see #113) * changed default rebuild tau to 365 to better reflect literature * Fixed possible problem if final demand category index is not given to ``parse_mriot_from_df``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the module:
https://github.com/CLIMADA-project/climada_petals/blob/develop/climada_petals/engine/supplychain.py
On line 304, the mriot unit is assigned in M.EUR.
According to the official data download https://www.rug.nl/ggdc/valuechain/wiod/ and opening the excel table, the unit must be in M.USD
![image](https://private-user-images.githubusercontent.com/116871277/306565623-f96ce689-775c-4bf8-b733-fb8bc03e6aa5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MTE1OTUsIm5iZiI6MTczOTkxMTI5NSwicGF0aCI6Ii8xMTY4NzEyNzcvMzA2NTY1NjIzLWY5NmNlNjg5LTc3NWMtNGJmOC1iNzMzLWZiOGJjMDNlNmFhNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxOFQyMDQxMzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNmU1YzE1YmRlYjM5MmEwMTY1M2QwZWRlOGZjOGYwZDg0OWI5ODM5MTczYTI2ZDIxMTkyYmI0YmE4ZDdmNmJmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.vYH4Ygc8eUKZ-Vwd4ziYMemh3WDMSpl-Jj5F4pVMZRE)
The text was updated successfully, but these errors were encountered: