Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA's OAuth Token Response has String expires_in #806

Open
suyashkumar opened this issue Nov 9, 2022 · 0 comments
Open

BCDA's OAuth Token Response has String expires_in #806

suyashkumar opened this issue Nov 9, 2022 · 0 comments

Comments

@suyashkumar
Copy link

Hi there! I noticed that BCDA's OAuth Token response provides a string value for the expires_in parameter.

If I'm reading the OAuth RFC correctly, expires_in should be a numeric value instead of a string value (e.g. not quoted in JSON).

Functionally what that means is that expiresIn needs to be returned as a numeric here:

body := []byte(fmt.Sprintf(`{"access_token": "%s", "expires_in": "%s", "token_type":"bearer"}`, token, expiresIn))
.

Let me know if I can help.

Cheers,
-Suyash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant