New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #29

Open

czwartaoslpoj opened this issue Aug 5, 2022 · 0 comments

Assignees

Labels

Examples

Collaborator

czwartaoslpoj commented Aug 5, 2022

Fix code smells caught by SonarLint regarding:

In RSA_encrypt, RSA_decrypt and constructor Client methods, instead of raising general Exception, raise custom ClientError.
Create constants.py file, where all the constants will be stored. Since "application/json" constant is needed in client.py as well as in connection.py it's better to store it in this additional file.
Remove unneeded 'pass' statement in set_ppk() function (client.py).

czwartaoslpoj added the Examples label

czwartaoslpoj self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment