-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devise naming structure for scripts in this repo #38
Comments
I think, contrary to what @AndyHoggANU was implying/suggesting during the MOM meeting on Apr 2nd, that the repository will benefit a lot if the Having code/notebooks that don't work or with no comments explaining to user to the bare minimum what the code is trying to achieve is, in my opinion, a bad practice. To be honest, a major reason I was pulling back initially from using the 10 examples that work and nicely explain what is going on are much better than 100 examples that mostly/partly work sometimes but only their authors know what they are trying to compute (and that given not much time has passed so that even the authors have forgotten everything). That said, I propose a much more major restructure from what the issue subject suggests. Disclaimer: It may sound a bit more drastic than simply "a naming structure". I suggest we drop the concept of In short: let's make all examples documented ones. I think that something along those lines would improve the repository and, consequently, benefit the COSIMA community and beyond... Opinions? @AndyHoggANU, @aekiss, @rmholmes, @aidanheerdegen, @angus-g, @kialstewart, others? |
I agree that However, one issue with getting rid of |
But @rmholmes, uncommented code is useless... similarly to uncommented jupyter-notebook cells. This is a public repository, not each persons notes. The bar should be a bit higher, indeed. That would be better for everybody (mostly for newbies) in the long run. I insist, that messy contributed examples create confusion... I'm not implying that each person should do this by themselves. What I suggest, is that when somebody pushes a PR with a |
Perhaps. I was thinking that there was a difference between commented code (which I totally agree is essential) and a documented example (which is much more extensive in terms of explaining how and why things are done the way they are). But I'm happy to be corrected. |
A notebook that consists of a series of |
hm... perhaps we are getting into semantics here (and that's diverting our focus). I'll try go through the contributed examples and point out which ones might make no sense and need either deletion or some comments |
How about this - during the hackathon, people can develop and improve contributed examples. Any documentation they put there is to be encouraged. When they do their pull request, then the administrator can choose to either upgrade it to a documented example (adding additional documentation if needed) or leave it there. Deleting ContributedExamples is an aspirational goal. Let's install the sandbox and see how ContributedExamples evolves ... |
BTW, I have added a Sandbox directory |
in #53? doesn't seem that you did.. |
Note that git requires some kind of a file inside a directory, or it'll be ignored. Could be as simple as an empty |
Yeah, that was probably where I went wrong ... |
I added a |
Should we close this? We're now discussing naming structure in the MOM6 issue instead. |
No description provided.
The text was updated successfully, but these errors were encountered: