Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence calculation hangs when NS/BH populations are run with cosmic-pop #561

Open
katiebreivik opened this issue Jul 13, 2022 · 0 comments

Comments

@katiebreivik
Copy link
Collaborator

If a user specifies that they want to simulate NS and BH populations in a single cosmic-pop run, the Knuth binwidth calculation takes a long time (sometimes days (!)) to compute the binwidth for the mass histograms in the convergence calculation. This makes the calculation intractable and we should probably generate some warnings for folks who are trying to do this.

Some options for warnings:
(1) warn when 13 and 14 are specified for final kstars
(2) warn when mass ranges below 3Msun and above 3Msun in convergence calculation

An option for future catches:
(1) split the match calculation for NS/BH masses up for > 3 Msun and < 3 Msun similar to eccentricity catches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant