Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address disjunctions #19

Open
fjmanion opened this issue May 4, 2018 · 1 comment
Open

Address disjunctions #19

fjmanion opened this issue May 4, 2018 · 1 comment
Labels
Lower Order Concerns

Comments

@fjmanion
Copy link
Member

fjmanion commented May 4, 2018

Disjunctions aren't appropriate classes. Hence, 'federal agency or department head' isn't an appropriate class. 'Federal Agency' should be a class under 'organization' and 'Department head' should be a role that can inhere in a homo sapiens.

Originally submitted by Neil Otte.
@fjmanion
Copy link
Member Author

fjmanion commented May 4, 2018

Agreed. These never occur separately in the Common Rule. When I was drafting early versions of the ontology, breaking the disjunction was causing combinatoric explosion of terms, so I avoided breaking it, but never got back to it. We should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lower Order Concerns
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fjmanion