Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific Incident Information #20

Open
yaswant2403 opened this issue Nov 21, 2024 · 2 comments
Open

Specific Incident Information #20

yaswant2403 opened this issue Nov 21, 2024 · 2 comments

Comments

@yaswant2403
Copy link
Collaborator

yaswant2403 commented Nov 21, 2024

When you click on a marker, you should display the information about that specific incident. It might be easier if you make a Custom Callout Component that gets shown whenever the user presses on a marker.

Callouts: https://github.com/react-native-maps/react-native-maps/blob/master/docs/callout.md

Custom Callouts: https://blog.spirokit.com/maps-in-react-native-adding-interactive-markers#heading-customizing-the-callout-component

@yaswant2403
Copy link
Collaborator Author

yaswant2403 commented Dec 3, 2024

Great! 21336d1 uses modals instead of callouts to achieve the same effect.

One small fix and then we can merge into main:

  • Use the incident and severity labels from import { INCIDENT_TYPE_LABELS, SEVERITY_LEVEL_LABELS, PIN_COLORS } from '@/constants/Incidents' rather than displaying the raw severity and incident type fields. This just ensures we're using the same labels throughout all the screens

@PrachodK
Copy link
Collaborator

PrachodK commented Dec 4, 2024

done and pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants