Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DZTR model missing Zone 3A for multi-year reservoirs #29

Open
1 task
BernardoTeufel opened this issue Mar 1, 2024 · 0 comments
Open
1 task

DZTR model missing Zone 3A for multi-year reservoirs #29

BernardoTeufel opened this issue Mar 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@BernardoTeufel
Copy link

Setup Information

  • Raven version: v453 (latest)
  • Operating System: Ubuntu 20.04

In Yassin et al. (2019) <https://doi.org/10.5194/hess-23-3735-2019>:

scenario A is used for reservoirs that have multi-year capacity (c > 0.5), and scenario B is used for reservoirs that have within-year capacity (c < 0.5)

This refers to Zone 3 (equations 5a and 5b in the paper). Only equation 5b made it into Raven. Perhaps the best solution is to add another parameter to the DZTR model in Raven so that the user specifies which scenario/equation to use for each reservoir.

Description

No response

Steps To Reproduce

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to address this bug.
@BernardoTeufel BernardoTeufel added the bug Something isn't working label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant