From 906ab0a1c8fec620eecddea7200b299179f9ebba Mon Sep 17 00:00:00 2001 From: "Nicholas C. Zakas" Date: Fri, 10 Feb 2012 14:57:02 -0800 Subject: [PATCH] Fix unqualified attribute issue (fixes #237) --- src/rules/unqualified-attributes.js | 4 ++-- tests/rules/unqualified-attributes.js | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/rules/unqualified-attributes.js b/src/rules/unqualified-attributes.js index 690718b5..375457a9 100644 --- a/src/rules/unqualified-attributes.js +++ b/src/rules/unqualified-attributes.js @@ -29,8 +29,8 @@ CSSLint.addRule({ if (part.type == parser.SELECTOR_PART_TYPE){ for (k=0; k < part.modifiers.length; k++){ modifier = part.modifiers[k]; - if (modifier.type == "attribute" && (!modifier.elementName || modifier.elementName == "*")){ - reporter.report(rule.desc, modifier.line, modifier.col, rule); + if (modifier.type == "attribute" && (!part.elementName || part.elementName == "*")){ + reporter.report(rule.desc, part.line, part.col, rule); } } } diff --git a/tests/rules/unqualified-attributes.js b/tests/rules/unqualified-attributes.js index f7efcfd5..28836d16 100644 --- a/tests/rules/unqualified-attributes.js +++ b/tests/rules/unqualified-attributes.js @@ -24,8 +24,14 @@ "Using an unqualified attribute selector in the middle should not result in a warning": function(){ var result = CSSLint.verify("[type=text] .foo { font-size: 10px; } ", {"unqualified-attributes": 1 }); Assert.areEqual(0, result.messages.length); + }, + + "Using a qualified attribute selector should not result in a warning": function(){ + var result = CSSLint.verify("input[type=text] { font-size: 10px; } ", {"unqualified-attributes": 1 }); + Assert.areEqual(0, result.messages.length); } + })); })();