Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect/misleading dV in 16.5 #27

Open
joneskun opened this issue May 3, 2015 · 3 comments
Open

incorrect/misleading dV in 16.5 #27

joneskun opened this issue May 3, 2015 · 3 comments

Comments

@joneskun
Copy link

joneskun commented May 3, 2015

pix http://imgur.com/fS0zeji
craftz http://pastebin.com/VhujDySU

@Gerry1135
Copy link
Contributor

This is almost certainly because the root part of the vessel is not in stage 0. The simulation code simulates the root part of the vessel and all the parts attached and because nothing "important" is decoupled from the root part when you stage (i.e. no engines or fuel tanks are decoupled) the simulation stages the pod and other bits immediately assuming you want to maximise the deltaV available.

There are changes being planned that will address this shortcoming but they are complex and require more free time than I have available to implement at present. In the meantime, you will need to make sure that the root part of your vessel doesn't get decoupled from the remainder of the craft, in this case, change the root part to be the command pod, and the calculations will be correct.

@zeroinformatique
Copy link

Isn't it easier to simply display a warning if the root part gets staged during the simulation, and stop the simulation at this level?
Giving wrong numbers is a lot worse than giving no numbers at all.

@arekbulski
Copy link

Thats is a fair point, but I suspect that checking for this condition is as complex as solving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants