Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect phase angle #46

Open
Gnurfos opened this issue Jul 5, 2015 · 0 comments
Open

Indirect phase angle #46

Gnurfos opened this issue Jul 5, 2015 · 0 comments

Comments

@Gnurfos
Copy link

Gnurfos commented Jul 5, 2015

The "phase angle" is displayed in "rendez-vous" information when a target is selected.
Currently only 2 cases seem to be handled correctly:

  • I am orbiting the same body as my target
  • the target is orbiting the same body as my "reference body"

I think the algorithm could be a bit more generic, and search the closest common ancestor between me and my target, and take its 2 descendants' orbits.

Example: I am orbiting Laythe and want to get back to Kerbin. Currently I think KER is displaying a meaningless angle between Laythe and Kerbin.

Sun > Kerbin(target)
Sun > Jool > Laythe > Ship

The common ancestor is the Sun. The 2 descendants are Kerbin and Jool. The phase angle displayed would be that between Kerbin and Jool.

I think the calculation is easy (sorry I'm not familiar with the language and don't have windows so I cannot do it); the challenge would be to show to the user somewhere what bodies are used. However, the current situation is already quite cryptic, so not showing anything would not be a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant