Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massive decrease in poller performance due to unset variable #4008

Closed
TheWitness opened this issue Dec 16, 2020 · 0 comments
Closed

Massive decrease in poller performance due to unset variable #4008

TheWitness opened this issue Dec 16, 2020 · 0 comments
Labels
blocker Blocking release bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.17

Comments

@TheWitness
Copy link
Member

Describe the bug

Cacti Fix #3808 introduced a regression in the read_config_option() function call that would result in a massive decrease in poller performance in cases where the variable was not set in the database. This increases both query load, and decreases poller performance.

To Reproduce

Steps to reproduce the behavior:

  1. Note your data collector timing.
  2. unset the 'selective_debug' variable in the settings table via 'delete from settings where name = "selective_debug"'
  3. Note your new data collector timing

Expected behavior

Poller performance should stay nimble when variables are not set.
@TheWitness TheWitness added bug Undesired behaviour blocker Blocking release labels Dec 16, 2020
@TheWitness TheWitness added this to the v1.2.17 milestone Dec 16, 2020
TheWitness added a commit that referenced this issue Dec 16, 2020
@TheWitness
Fixing Issue #4008
7b7b713 
This is a partial rollback of issue #3808 due to negative impact it has on both GUI and Data Collector performance.
@TheWitness TheWitness added the resolved A fixed issue label Dec 18, 2020
This was referenced Dec 24, 2020
Merged
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
@netniV netniV changed the title Fix #3808 causes a massive decrease in poller performance Massive decrease in poller performance due to unset variable Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocker Blocking release bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
1 participant
@TheWitness