Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug message format unification #263

Open
xmacan opened this issue May 4, 2022 · 4 comments
Open

Debug message format unification #263

xmacan opened this issue May 4, 2022 · 4 comments
Milestone

Comments

@xmacan
Copy link
Member

xmacan commented May 4, 2022

Few Lines have DEBUG: Device[xx] and the rest Device[44] DEBUG

2022-05-04 10:20:03 - SPINE: Poller[1] PID[45643] PT[34376899840] DEBUG: Device[44] HT[1] In Poller, About to Start Polling
2022-05-04 10:20:03 - SPINE: Poller[1] PID[45643] PT[34376899840] Device[44] DEBUG: Entering ICMP Ping
2022-05-04 10:20:03 - SPINE: Poller[1] PID[45643] PT[34376899840] Device[44] DEBUG: Attempting to ping ......, seq 0 (Retry 0 of 3)
2022-05-04 10:20:03 - SPINE: Poller[1] PID[45643] PT[34376899840] Device[44] DEBUG: ICMP Device Alive, Try Count:1, Time:5.0600 ms
2022-05-04 10:20:03 - SPINE: Poller[1] PID[45643] PT[34376899840] Device[44] DEBUG: Entering SNMP Ping
2022-05-04 10:20:03 - SPINE: Poller[1] PID[45643] PT[34376899840] DEBUG: Device[44] HT[1] RECACHE: Processing 3 items in the auto reindex cache for '......'
2022-05-04 10:20:04 - SPINE: Poller[1] PID[45643] PT[34376899840] DEBUG: Device[44] HT[1] DEBUG: HOST COMPLETE: About to Exit Device Polling Thread Function

Spine 1.2.20

@TheWitness TheWitness added this to the v1.2.22 milestone May 4, 2022
@bernisys
Copy link

Additionally, several messages that are device related (for example the debug lines for polled values) don't contain a device ID, but only the IP/name of the device.

Would be helpful to have a kind of unified message-header for each type of log message, so that all necessary clues are inside each message.

@netniV
Copy link
Member

netniV commented Aug 17, 2022

I would agree there are some inconsistency on the output there, likely due to bad fingers and different developers 💯

@netniV
Copy link
Member

netniV commented Aug 17, 2022

Don't think this made the 1.2.22 milestone though

@TheWitness
Copy link
Member

Going to move this to 1.2.24

@TheWitness TheWitness modified the milestones: v1.2.22, v1.2.23, v1.2.24 Nov 20, 2022
@TheWitness TheWitness modified the milestones: v1.2.24, v1.3.0 Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants