Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: popup does not appear on Fosstodon #208

Open
Jackymancs4 opened this issue Aug 12, 2020 · 6 comments
Open

Bug: popup does not appear on Fosstodon #208

Jackymancs4 opened this issue Aug 12, 2020 · 6 comments

Comments

@Jackymancs4
Copy link
Contributor

Jackymancs4 commented Aug 12, 2020

Describe the problem
The popup does not appear on any page on https://fosstodon.org

How to reproduce the problem
Steps to reproduce the behavior:

  1. Go to https://fosstodon.org/about
  2. Select any text
  3. The popup does not appear, but the scroll bar move, indicating that something has been appended on the bottom of the page (out of view)

Anything else you'd like to include
Hello @CanisLupus
Usually I'd take care of this myself, but I'm a little short on time. I briefly messed around with CSS but with no result.
So, it appears that SSS fails on any Mastodon server using 3.2.0, while on https://mastodon.technology/about (that uses 3.1.x) it works normally.
In any case, <sss-popup> tag is properly inserted, so I guess is strictly a styling issue.
Thanks.

System info:

  • Browser: Firefox
  • Browser version: 79.0
  • System: macOS
@ZIEXED
Copy link

ZIEXED commented Aug 12, 2020

Everything is working normally here.

@Jackymancs4
Copy link
Contributor Author

Everything is working normally here.

Can you be more specific about what is working and under which conditions?

@CanisLupus
Copy link
Owner

Hey @Jackymancs4, for better or worse I can confirm that it happens on my end as well (Windows, FF 79). It's probably due to the website's content security policies, since this error appears in the console for me when the popup is supposed to appear:

Content Security Policy: The page's settings blocked the loading of a resource at inline ("style-src").

That's blocking the popup's CSS from working.

I thought I had solved this by modifying the CSP of pages when needed, so I'm not sure what is different with that site or what I'm doing wrong (or if something changed in Firefox itself). Doing the CSP modification is, as far as I know, the only way to avoid this problem, i.e. "consider addon rules more important than website rules, since addons represent the user". However, it's not working here. Hmm...

@CanisLupus
Copy link
Owner

I have also tried this on a clean FF profile with only SSS to see if it was some other extension also modifying the CSP and conflicting, but it still happens.

@ZIEXED Do you have any idea what could be different on your end?

@ZIEXED
Copy link

ZIEXED commented Aug 13, 2020

Sorry I forgot that I have CSP disabled here, I can see the problem after enabling it again.

@CanisLupus
Copy link
Owner

Ah, thanks for checking. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants