Suggestion: custom icons for "copy" and "open as link" / Problems with popup on two websites

[drmusti]

please add a lot of features :)
and dont work features.

1)possible icon offline import?
2) Copy to clipboard and Open as link icons custom icons addable.

3)https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe
example sites areas dont work popup....

https://codepen.io/carwin/details/dxbCi

please add features. and your extention more great...
thanks
Sincerely.
sorry my bad english?
can u understand my proplem?

[CanisLupus]

UPDATE: Ignore this message, The post has been cleaned up. ;)

Hi there! Thanks for creating the issue here.

I think I understand at least part of it, but you duplicated some things like images. I don't know how many different things this is! 😅 3? 4? 5? You have a title that says it's "three features" but the issue has 5 different points. Then those 5 points are followed by 2 features that are actually 3 features (but two are duplicates of previous ones), so I'm very confused.

Can you please clean-up your request? :)

[CanisLupus]

And like I said in the reply to the review, if you want the es:{searchTerms} engine to not create a new tab, please use the "Discard on open" checkbox that each search engine has in SSS. It avoids creating a new tab.

[drmusti]

i cleaned my request.
Sincerely.

[CanisLupus]

Thank you for the cleanup, it's much better. :)

1. Unfortunately, loading icons from a file doesn't work in the popup due to security policies. This is tracked in issue file:// icons not shown in popup #135 but I currently don't know if there's a way to solve it.

2. Hmm... While I see why you could want this, it will probably not get implemented in SSS unless another special "engine" like "copy" or "open as link" gets added where this would make sense (in that case we could add support for custom icons on all of them). Right now these special engines are programmed differently from the others internally, and this feature wouldn't be useful for the vast majority of users. :)

3. Thanks for reporting these websites.

   https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe

   Although it looks like an editable text area, I think this site does it weirdly so the text area is actually not editable but there's a floating "textarea" tag of width 1 just so you can write characters one at a time. Even so, that doesn't tell me why the selection doesn't get triggered.

   https://codepen.io/carwin/details/dxbCi

   This one is also weird. Perhaps this doesn't work because it is a new HTML document inside an iframe. I'd have to research this more deeply as well.

Cheers!
Daniel

[CanisLupus]

I also edited the title of this issue to reflect the issues (except 1, which is in #135).

[drmusti]

my icons very great very nice very soft very colorful.

[drmusti]

new proplem your translate without formating... no paragraph no
etc...

[CanisLupus]

my icons very great very nice very soft very colorful.

Yeah, I imagined that this was why you wanted to customize those icons. :)

new proplem your translate without formating... no paragraph no etc...

Thanks for reporting this. I've created a new issue (#228) for this, so that we're not dealing with multiple issues here (although there's 2 already ;P).

[drmusti]

you are a very kind honest helpful programmer.
thank you very much big coder.

[CanisLupus]

Hahah thank you! ;)

[drmusti]

new bug... error..

https://yadi.sk/i/aUkSfW5DSYUwWA

wait page loaded.
select text.
but you cant a click
button. and you cant
close popup...
two proplem...

[CanisLupus]

Hi @drmusti, I could not reproduce this here. For me it opens, buttons are clickable, and it closes.

Please make sure that you don't have another addon conflicting with SSS (try disabling them and refreshing the page to see if it works). If it doesn't work with everything else disabled, then I'm not sure what it could be.

[drmusti]

i found that extention.
Absolute Enable Right Click & Copy
i removet it.
thank you for solution.

[CanisLupus]

Ah good, glad it was just that. :)

[drmusti]

i too :))))
Absolute Enable Right Click & Copy is not important extention. basic simple addon...
Sincerely

[drmusti]

i found new proplem
after & lost texts


:))))
Sincerely

[CanisLupus]

Haha you are good at finding problems with some websites. :)

Thanks for reporting this. It seems that Google Translate doesn't like the conversion of the & character if the fragment #view=home is present. I had no idea.

Please try this as the engine's Search URL:
https://translate.google.com/?sl=auto&tl=en&op=translate&text={searchTerms}

(instead of the old https://translate.google.com/#view=home&op=translate&sl=auto&tl=en&text={searchTerms})

Does this work?

[CanisLupus]

(Of course feel free to change the target language from en to tr)

[drmusti]

good worked.
you are good at finding solutions. great and fast solution :)))) cleverly congratulations
but translate popup new line paragraph type proplem still ....
:))))

and copy & open it buttons custom icon url features :(
and other not fired selection popup proplems.
:)))))))))))))))))
Sincerely

[CanisLupus]

OK, I'll probably change the "translation" engine in the eventual next update to fix this.

True, but the other issues will need a lot more research to fix (if they are even possible to fix). :)

[drmusti]

I believe you will be able to solve them all. because you re best coder big programmer.
sorry for my bad english.