Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refreshExpression does not send a SQL request to the backend DB at the specified intervals #370

Open
NithinKumaraNT opened this issue May 6, 2024 · 3 comments
Labels
needs-triage type/bug Something went wrong

Comments

@NithinKumaraNT
Copy link

NithinKumaraNT commented May 6, 2024

Environment

  • Version:
    v0.10.4

  • OS: macOS - x86

What's wrong?

The refreshExpression seems to not function. It does not invalidate the cache and refresh it based on the SQL expression.
Backend DB : BigQuery

The following is the example YAML config :

....

sql: |
      SELECT
        *
      FROM
        mytable
    profile: bq
    refreshExpression:
        expression: "MAX(_processed_at)"
        every: "30s"

Please note that just using the refreshTime works without problems.

What's the correct behavior?

A SQL request should be sent every 30 s based on the above config to BigQuery to check and invalidate the cache.

Reproducing steps

@NithinKumaraNT NithinKumaraNT added needs-triage type/bug Something went wrong labels May 6, 2024
@onlyjackfrost
Copy link
Contributor

Hi @NithinKumaraNT
refreshExpression is not fully implemented yet, you can only use refreshTime for now.

@NithinKumaraNT
Copy link
Author

Hi @onlyjackfrost, If I can ask, when can we expect this feature :) ?

@onlyjackfrost
Copy link
Contributor

I can't tell, since we are focusing on https://github.com/Canner/WrenAI currently.
But I'll take a look maybe this weekend or the next...

If you would like to contribute, I'm glad to guide you through the codebase =D
You can pin me on Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage type/bug Something went wrong
Projects
None yet
Development

No branches or pull requests

2 participants