Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle - Design System #681

Open
jgonza16 opened this issue Aug 14, 2024 · 0 comments
Open

Toggle - Design System #681

jgonza16 opened this issue Aug 14, 2024 · 0 comments

Comments

@jgonza16
Copy link
Collaborator

jgonza16 commented Aug 14, 2024

Toggle - Design System

1 - Prerequisites

  • Host element will have the .dcx-toggle class name
  • Host element will have sub-element with .dcx-toggle-custom-on-label class name
  • Host element will have sub-element with .dcx-toggle-custom-off-label class name

2 - Overview

2.1 - Possible states

Name Description
Default Instance without specific properties defined
Disabled Instance with native input disabled
Filled (Checked) Instance with value
Focus Instance while receiving focus on native input

2.2 - Variants

Name Description
Default Default look & feel

2.3 - Structure

Element Description  Token Name
InputBox The container box label element  formcontro_boxl
Input The native input itself  formcontrol
CustomOnLabel The label custom element  formcontrol_label
CustomOffLabel The label custom element  formcontrol_label

When developing take a close look to the FormSelect component. It is a form element as well, the tokens and styling approach should be similar.

2.4 - Tokens definition

Considerations:

  • ❗ Take a close look to the FormSelect component. It is a form element as well, the tokens and styling approach should be similar.
  • Add the tokens to src/design-system/tokens.json
  • Define all styles in src/design-system/toggle.css
  • Add import to the new CSS file in src/design-system/index.css

Possible tokens:

  • color-text-formcontrol
  • color-text-formcontrol-filled
  • color-text-formcontrol_label
  • color-text-formcontrol_label-filled
  • etc.

Follow the naming pattern

3 - Storybook

Create the pages for:

  • Playground
  • Default
  • AccessibleTheme
  • DarkTheme
  • MaterialTheme

On each MDX page make examples for each possible variant

4 - Initial setup

Please follow these steps to create your branch:

git checkout release/1.0.0
git pull
git checkout -b 'feature/toggle-design-system'
@jgonza16 jgonza16 changed the title Toggle - Design System [PLACEHOLDER-TICKET] Toggle - Design System Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant