Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend CCRP - Authentication #33

Closed
Khyati729 opened this issue May 3, 2024 · 4 comments
Closed

Backend CCRP - Authentication #33

Khyati729 opened this issue May 3, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers ODHack

Comments

@Khyati729
Copy link

Khyati729 commented May 3, 2024

As carbonable
I want to add an auth module
In order to secure api access

[nodeJS/TypeScript]

Rules

  1. Use this documentation to create the authentication management with JWT
  2. Users can have the role admin or user - Documentation
  3. Make all the existing api public
  4. Create the "create user" (login, password, default role is user) api which is only accessible for an admin
  5. Create the swagger doc in the controller
@schwepps schwepps changed the title Backend CCRP - Login Backend CCRP - Authentication Jun 17, 2024
@Khyati729 Khyati729 added good first issue Good for newcomers ODHack labels Jun 19, 2024
@schwepps schwepps self-assigned this Jun 19, 2024
@fishonamos
Copy link

fishonamos commented Jun 20, 2024

I will love to work on this. I handled Juno integration to Carbonable. Merged pr here.

Tackling this issue will involve setting up JWT authentication with jsonwebtoken and bcryptjs and also creating middleware for token verification / implementing functions for token generation and validation. I will also define user roles to restrict access to specific endpoints.

@LouGel
Copy link
Contributor

LouGel commented Jun 20, 2024

Id love to improve my skills on NestJs on this.

@schwepps
Copy link
Member

Hi @fishonamos and @LouGel! Thanks for your interest in Carbonable and this issue.
I'm really sorry @fishonamos, @LouGel is going to work on this issue.
We had started the discussion outside github before you asked. It's a bit off process and we will do better next time.
I hope you'll find on other issue to work on.
Unfortunately we don't have a lot of nodeJS issue this time but we will have more for the next OD Hack.

@schwepps schwepps assigned LouGel and unassigned schwepps Jun 20, 2024
@fishonamos
Copy link

Thats fair @schwepps, since you have started a conversation on the issue with @LouGel. I commented on this issue to Upgrade the all repository from Cairo 2.2.0 to 2.6.0 with it's dependencies

@LouGel LouGel closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack
Projects
None yet
Development

No branches or pull requests

5 participants