Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dark mode and focus change #17

Open
kaal-coder opened this issue Oct 18, 2022 · 11 comments
Open

Fix the dark mode and focus change #17

kaal-coder opened this issue Oct 18, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs

Comments

@kaal-coder
Copy link
Member

These are present in the code but not in a proper way, hence aren't visible on the website.
Fix this issue.

@kaal-coder kaal-coder added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest up-for-grabs labels Oct 18, 2022
@DevDK12
Copy link

DevDK12 commented Oct 18, 2022

I would like to work on this

@DevDK12
Copy link

DevDK12 commented Oct 18, 2022

I have already fixed this problem , you can assign me this

@DevDK12
Copy link

DevDK12 commented Oct 18, 2022

And also tell me what do you mean by focus change here . Could you explain it in detail more

@kaal-coder
Copy link
Member Author

@DevDK12 On focus change, the title changes to - "Don't give up champ !"

@kaal-coder
Copy link
Member Author

Nope. If tab is changed to any other tab, then the title changes. Refer - Stack Overflow

DevDK12 added a commit to DevDK12/Sudoku-Solver that referenced this issue Oct 18, 2022
@kaal-coder
Copy link
Member Author

@DevDK12 make a PR if you have done.
Make sure your branch is updated

@DevDK12
Copy link

DevDK12 commented Oct 20, 2022

@DevDK12 make a PR if you have done. Make sure your branch is updated

I have already made a PR request yesterday only and while commiting it was already updated. You should atleast review it

@kaal-coder
Copy link
Member Author

@DevDK12 Check the reason why your PR was closed - #19 (comment)

@Pratik-k-sahoo
Copy link
Contributor

I have solved the issue please can you assign me this issue?

@Pratik-k-sahoo
Copy link
Contributor

Added the dark and light mode with icon change.
Also added the focus change i.e when changes tab then document title changes and alert and notification saying "Don't Give Up Champ".

@Pratik-k-sahoo
Copy link
Contributor

Pratik-k-sahoo commented Oct 30, 2023

the dark and light mode was assigned to me with the focus change. As @ankit071105 have done the dark mode part thats why in mine its showing conflict. what to do?
Any suggestion? @kaal-coder as it was assign to me.
for till now I am not doing the dark mode part apart from that I have done the focus change part. So please review and merge with the hacktoberfest tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

3 participants