Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front of Card Image not the default #1929

Open
AndyM48 opened this issue Jun 15, 2024 · 4 comments
Open

Front of Card Image not the default #1929

AndyM48 opened this issue Jun 15, 2024 · 4 comments
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented type: enhancement New feature or request

Comments

@AndyM48
Copy link

AndyM48 commented Jun 15, 2024

If I choose an image for the front of the card it is not automatically shown as the thumbnail for that card. I wonder what the thought process was behind this decision?

@TheLastProject
Copy link
Member

TheLastProject commented Jun 15, 2024

Originally the thumbnail was a completely different size so the front image wouldn't fit in the thumbnail area well.

Nowadays the sizes are the same so it might make sense to have this behaviour (especially because for some reason people don't seem to be able to find the thumbnail setting).

However, that brings up the question...
Should the preview automatically use thumbnail -> front -> back (whichever exists)? Should it offer to set the thumbnail when setting the front image? Should it always offer this or only if the thumbnail hasn't been set? (Probably always).

Should be pretty easy to display a dialog box after setting the front image to ask to use it as thumbnail (would it confuse users when changing the back image?)

@AndyM48
Copy link
Author

AndyM48 commented Jun 15, 2024

I would think that if a front image is selected it should automatically be set to the thumbnail view. Subsequently setting a thumbnail should override any existing thumbnail.

I doubt anyone would want the back image to be used as the thumbnail, but if they did, then they could use the edit thumbnail to override the existing thumbnail.

Simple and no need for any new dialog boxes.

@TheLastProject
Copy link
Member

I hacked up a PoC yesterday in #1930 but after testing it I'm not quite sure if this is the best flow.

Catima has never shown the front or back image as thumbnail before. In the many years it has existed, many users have surely used this functionality to store unrelated images in it that are unsuitable as thumbnails and using those as thumbnails without any user intervention is likely to cause frustrating experiences (even my own test data has some cases like that, leading to me not being able to recognize the cards anymore).

I think #1675 is probably a much better idea to implement, possibly together with asking the users when they set a new front/back image if they also want to set it as thumbnail, to keep users in control. While I generally prefer to bother users with questions less, the one extra Yes/No seems to be worth reducing the frustrations and confusion many users may run into when implemented this way.

@AndyM48
Copy link
Author

AndyM48 commented Jun 16, 2024

I am sure that you are right.

the one extra Yes/No seems to be worth ...

May be default to Yes?

@TheLastProject TheLastProject added type: enhancement New feature or request state: consensus-needed A consensus needs to be reached before this can be implemented labels Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants