Do not reset search results after exiting the card view window

[Korb]

Sequence of actions for playback:

1. Enter a search query in the application, and the search will find something.
2. Click on any card.
3. Use the system Back gesture (or its equivalent, depending on your graphical shell).

Current result

The full list of cards is displayed, the search field is empty.

Desired behavior

The search results screen is displayed and the search bar displays what you entered in step 1.

Rationale

The user can click past the desired position in the search results, which is normal when you have purchases, a wallet, a smartphone in your hands, and there is a line of impatient buyers behind you. Or the user has several cards entered into the application, and he either does not know from the search results which one he needs, or asks the cashier to sequentially check, for example, the discount percentage for each of them. All of the above becomes much more complicated if you need to re-enter the search query each time, remembering which cards you have already looked at and hoping that the search results do not change their position in the list.

Workaround

Use the scroll arrows at the bottom of the card viewing screen. It seems that they are sequentially scrolling through cards screens from search results or the current group.

[angrezichatterbox]

Is this issue open to be solved ??

[TheLastProject]

I'm not currently working on this. If you want to, feel free to send a PR :)

[vp193dt]

Hello is this Issue open? I would like to contribute to project, thank you for info.

[TheLastProject]

Ignore my last message, I keep getting this and #1977 confused. This issue is indeed still open :)

[vp193dt]

Perfect thank you very much for information, I will be working on this Issue in next days :)

[TheLastProject]

That sounds great, thanks! If this is intended to be a Hacktoberfest contribution, make sure to not create the pull request before October 1st (or it won't count as per their rules) :)

I took another quick look at it and it seems to also reset the search when you rotate the screen, so this is most likely an issue with onResume() resetting the search filter or something (probably some code in onResume() that should've been in onCreate() in the MainActivity or some other issue with incorrect state restoration. But I haven't looked at it more deeply so this is just a hunch.

[vp193dt]

Hello I have changes ready for preview but Im unable to create pull request due to permissions error 403, can this be somehow bad on your side?
Thank you.

[TheLastProject]

@vp193dt I just took a look at your profile and I don't see any fork of the Catima repo so my best guess is that you forgot to fork, which would explain the issue as you don't have permission to push code straight to CatimaLoyalty/Android on GitHub.

You'll want to hit "Fork" on the top-right on https://github.com/CatimaLoyalty/Android, make your changes in your copy and then after you're done go to https://github.com/CatimaLoyalty/Android/pulls and click "New pull request" in the top-right. More info on https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo :)