From 0762dab93a4cbb93cc18c2770ef167684eb7f72f Mon Sep 17 00:00:00 2001 From: Sean Lilley Date: Tue, 13 Feb 2024 11:18:25 -0500 Subject: [PATCH 1/3] Remove unused code --- src/core/src/Context.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/src/Context.cpp b/src/core/src/Context.cpp index 88812132..8faa6541 100644 --- a/src/core/src/Context.cpp +++ b/src/core/src/Context.cpp @@ -134,8 +134,6 @@ void Context::clearStage() { } void Context::reloadStage() { - const auto defaultIonServerPath = pxr::SdfPath("/CesiumServers/IonOfficial"); - clearStage(); // Populate the asset registry from prims already on the stage From 5c7f5b2729197720e59686521ae5dfa0d3940bc2 Mon Sep 17 00:00:00 2001 From: Sean Lilley Date: Tue, 13 Feb 2024 11:32:48 -0500 Subject: [PATCH 2/3] Avoid sending USD notification when server doesn't change --- exts/cesium.omniverse/cesium/omniverse/usdUtils/usdUtils.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/exts/cesium.omniverse/cesium/omniverse/usdUtils/usdUtils.py b/exts/cesium.omniverse/cesium/omniverse/usdUtils/usdUtils.py index 0c7a3634..50091fd4 100644 --- a/exts/cesium.omniverse/cesium/omniverse/usdUtils/usdUtils.py +++ b/exts/cesium.omniverse/cesium/omniverse/usdUtils/usdUtils.py @@ -154,7 +154,11 @@ def get_path_to_current_ion_server() -> Optional[str]: def set_path_to_current_ion_server(path: str) -> None: data = get_or_create_cesium_data() rel = data.GetSelectedIonServerRel() - rel.SetTargets([path]) + + # This check helps avoid sending unnecessary USD notifications + # See https://github.com/CesiumGS/cesium-omniverse/issues/640 + if get_path_to_current_ion_server() != path: + rel.SetTargets([path]) def get_tileset_paths() -> List[str]: From 53a2438fdf061de55226fdf08f9373278f7771c3 Mon Sep 17 00:00:00 2001 From: Sean Lilley Date: Tue, 13 Feb 2024 11:35:16 -0500 Subject: [PATCH 3/3] Update CHANGES.md --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index e9019add..18d91a47 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -7,6 +7,7 @@ * Fixed crash when updating tilesets shader inputs. * Fixed crash when setting certain `/Cesium` debug options at runtime. * Fixed crash when disabling and re-enabling the extension. +* Fixed a bug where save stage dialog would appear when reloading Fabric stage at startup. ### v0.17.0 - 2024-02-01