Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libp2p from 0.51.1 #2762

Closed
LesnyRumcajs opened this issue Apr 14, 2023 · 6 comments · Fixed by #3115
Closed

Upgrade libp2p from 0.51.1 #2762

LesnyRumcajs opened this issue Apr 14, 2023 · 6 comments · Fixed by #3115
Assignees

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Apr 14, 2023

Issue summary
The recent upgrade #2732 most likely introduced a regression #2755

Reverting this upgrade seems to mitigate the issue (all my mainnet sync trials passed for Forest pinned to 0.51.1, whereas none passed with the updated libp2p). That was around ten trials.

The revert #2759 is a temporary workaround, the library should be updated, and the deprecated suppressions should be removed. These can be found by gripping this ticket link in the codebase.

⚠️ when updating libp2p, make sure it syncs to mainnet.

If it turns out that the issue is back again without the libp2p update, this one should be closed and the original bug ticket should get re-opened.

Other information and links

@LesnyRumcajs
Copy link
Member Author

LesnyRumcajs commented Jul 19, 2023

revertio again #3219

@LesnyRumcajs LesnyRumcajs reopened this Jul 19, 2023
@thomaseizinger
Copy link

Let us (@mxinden & myself) know if we can help you with the update! :)

@LesnyRumcajs
Copy link
Member Author

@thomaseizinger Thanks! I really appreciate it, I will reach out once I contrive a minimal reproducible example of the issue.

@hanabi1224
Copy link
Contributor

Update: the issue is likely to be related to libp2p/rust-libp2p#4250 @LesnyRumcajs has forest running well by raising the connection limit

@LesnyRumcajs
Copy link
Member Author

There were some other changes that may have helped, e.g., not banning peers when they abruptly close the connection.

@LesnyRumcajs
Copy link
Member Author

LesnyRumcajs commented Aug 10, 2023

Closed via #3267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants