-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade libp2p from 0.51.1 #2762
Comments
revertio again #3219 |
Let us (@mxinden & myself) know if we can help you with the update! :) |
@thomaseizinger Thanks! I really appreciate it, I will reach out once I contrive a minimal reproducible example of the issue. |
Update: the issue is likely to be related to libp2p/rust-libp2p#4250 @LesnyRumcajs has forest running well by raising the connection limit |
There were some other changes that may have helped, e.g., not banning peers when they abruptly close the connection. |
Closed via #3267 |
Issue summary
The recent upgrade #2732 most likely introduced a regression #2755
Reverting this upgrade seems to mitigate the issue (all my mainnet sync trials passed for Forest pinned to
0.51.1
, whereas none passed with the updated libp2p). That was around ten trials.The revert #2759 is a temporary workaround, the library should be updated, and the
deprecated
suppressions should be removed. These can be found by gripping this ticket link in the codebase.If it turns out that the issue is back again without the libp2p update, this one should be closed and the original bug ticket should get re-opened.
Other information and links
The text was updated successfully, but these errors were encountered: