Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curious why SignalPreKeyMessage appears to be unsupported #15

Open
Manbearpixel opened this issue Mar 5, 2020 · 1 comment
Open

Curious why SignalPreKeyMessage appears to be unsupported #15

Manbearpixel opened this issue Mar 5, 2020 · 1 comment

Comments

@Manbearpixel
Copy link

I've noticed in the codebase that most references to SignalPreKeyMessage have been commented out and thus unsupported for use.

Was there a specific reason or decision that led to this? In the JAVA library this appears to be used and is working.

One example: Classes/SignalSessionBuilder.m

/*
- (void) processPreKeyMessage:(SignalPreKeyMessage*)preKeyMessage {
    NSParameterAssert(preKeyMessage);
    if (!preKeyMessage) { return; }
    session_record *record = NULL;
    //int result = session_record_create(&record, <#session_state *state#>, <#signal_context *global_context#>)
    //int result = session_builder_process_pre_key_signal_message(_builder, <#session_record *record#>, <#pre_key_signal_message *message#>, <#uint32_t *unsigned_pre_key_id#>)
}
 */
@Manbearpixel
Copy link
Author

I'm trying to run through the test located in Testing/SignalProtocolTests/SignalProtocolObjCTests.m and am hitting Error Domain=org.whispersystems.SignalProtocol Code=4 "Invalid Key" UserInfo={NSLocalizedDescription=Invalid Key}

And am unsure how to resolve, or how the key could be invalid following the steps verbatim. Here I see a commented out reference to SignalPreKeyMessage but unsure if that was necessary there to have the test work properly.

Appreciate any guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant