Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "browser" environment variable to handle incompatibilities #86

Open
emilgoldsmith opened this issue Mar 18, 2017 · 3 comments
Open

Add "browser" environment variable to handle incompatibilities #86

emilgoldsmith opened this issue Mar 18, 2017 · 3 comments

Comments

@emilgoldsmith
Copy link
Contributor

emilgoldsmith commented Mar 18, 2017 •
edited
Loading

As talked about in #79 and #52.
@martynchamberlin
Copy link
Member

Not browser. OS!

@martynchamberlin
Copy link
Member

Oh. Sorry. Got mixed up what we were talking about. Yes, for this, browser. :)

@emilgoldsmith
Copy link
Contributor Author

Haha yeah. I guess we can only detect OS by javascript, not by distribution ;).

We can just add the environment variable in the webpack builds as we at build time know what the target browser is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martynchamberlin @emilgoldsmith