Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkForDelete Should Only Validate that can be deleted once been through entire tree of objects #28

Open
jeff2001 opened this issue Nov 14, 2013 · 0 comments

Comments

@jeff2001
Copy link
Contributor

Redmine Bug #424

At present if you try delete a DMClass in Firestarter and it has DMProps and DMRelationships then although DMClass tries to cascade delete DMRelationships and DMRelationship tries to cascade delete DMRelationshipProps and DMClass tries to cascade delete DMPRops you land up getting an error message that cannot delete these.
I have written a DMClassDeleter in firestarter to overcome this but seems like there should be a fix in Habanero.

Updated by Peter Wiles about 3 years ago
Thinking about this: would this impact on performance when marking a bunch of objects for delete? Could we maybe have a boolean on the MarkForDelete method (an overload) to specify whether to perform this check when calling the method? It might load up a whole tree of objects. I understand this is necessary when actually persisting, but devs will expect the MarkForDelete to be cheap since it's just marking the object for deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant