Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login, and stay on the page that you were on. #146

Open
thatrobotdev opened this issue Sep 20, 2017 · 3 comments
Open

Login, and stay on the page that you were on. #146

thatrobotdev opened this issue Sep 20, 2017 · 3 comments

Comments

@thatrobotdev
Copy link

thatrobotdev commented Sep 20, 2017

When I use devGaido, I have two bookmarks in my browser which go to the Frontend course, and the Fullstack course. Here are the steps to my login:

  1. Click Bookmark
  2. Click Login Button, and log in with my GitHub
  3. Get Redirected to Dashboard
  4. Click Bookmark again to get back to the course I wanted to look at

Instead, I was wondering if this is what could happen:

  1. Click Bookmark
  2. Click Login Button, and log in with my GitHub
  3. Browse the course I want to look at

I don't see a reason to redirect to the dashboard every time I log in since I use devGaido constantly to update my progress and don't like clicking my bookmark 2 times to get to one place.

@jdmedlock
Copy link
Collaborator

The original use case was that following Login the user would want to see overall progress before jumping to a particular bookmark. However, we'll look into this to see what is involved to honor bookmarks following a Login.

@thatrobotdev
Copy link
Author

Thank you @jdmedlock!

@jdmedlock
Copy link
Collaborator

This issue stems from the fact that we are using Auth0 for authentication and are experiencing some difficulties in persisting the bookmarked URL so its available after the return from Auth0. We are looking into this without opening any security holes (cookies are not the answer), but it will likely take some time and experimentation. We are leaving this issue open until we have identified and implemented a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants