Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre execute cannot see the data that will be synced/ignored/conflicts #1

Open
ChrisVilches opened this issue Sep 10, 2021 · 1 comment

Comments

@ChrisVilches
Copy link
Owner

ChrisVilches commented Sep 10, 2021

Just populate those arrays before pre-execute hook. Then executeSync simply executes the already populated stuff. ExecuteSync method needs to be divided into populate & execute.

Then execute them in this order.

Populate (itemsToSync, ignored, etc) → pre execute → execute

This is necessary, for example to push files from local disk to Amazon S3 which are tracked by a local DB (file upload is implemented in the pre execute hook, and that needs to know which files to upload.)

@ChrisVilches
Copy link
Owner Author

Probably finished. I think I wrote a test for this actually. Must confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant