From 84a7e789d11e7ef0b3d0a23ae22d737e62fc219b Mon Sep 17 00:00:00 2001 From: "Christian Tremblay, ing." Date: Thu, 16 Jan 2025 21:30:45 -0500 Subject: [PATCH] Attempt in fixing https://github.com/ChristianTremblay/BAC0/issues/352 --- BAC0/core/io/Read.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/BAC0/core/io/Read.py b/BAC0/core/io/Read.py index b18012e..0fc775d 100644 --- a/BAC0/core/io/Read.py +++ b/BAC0/core/io/Read.py @@ -49,6 +49,7 @@ def readMultiple() RangeByPosition, RangeBySequenceNumber, RangeByTime, + EngineeringUnits, ) from bacpypes3.errors import NoResponse, ObjectError from bacpypes3.object import get_vendor_info @@ -183,7 +184,14 @@ async def read( "Using a default value of On for internal needs." ) return "True" + if "units" in args: + self._log.warning( + "The units property is not implemented in the device. We will consider noUnits" + "Using a default value for internal needs. Please note that units is a required property for BACnet objects like analog values. The device you are reading from may be non-compliant." + ) + return EngineeringUnits("noUnits") else: + raise UnknownPropertyError(f"Unknown property {args}") else: self.log(f"Error : {err}", level="error")