Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdwan_ipv4_acl_policy_definition resource can have ICMP message type, but not supported #314

Open
cmohorea opened this issue Aug 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cmohorea
Copy link

When configuring matching in vManage, when you specify protocol 1, it allows to specify ICMP type.
image

in a schema, it seems to be a separate "icmpMessage" type, at least this is how it is understood by the provider when doing terraform import.
However, both type and sub-type values ("echo", "echo-reply", etc.) are not supported
Having this config (built based upon the imported data) results in error

      match_entries = [
        {
          source_data_ipv4_prefix_list_id = "50dc30b2-5915-4608-a302-0b8165ef603c",
          type = "sourceDataPrefixList",
        },
        {
          destination_data_ipv4_prefix_list_id = "0060c3a4-f9f2-4f15-b28e-ba60502d38eb",
          type = "destinationDataPrefixList",
        },
        {
          protocol = "1",
          type = "protocol",
        },
        {
          type = "icmpMessage",
        }
      ],
      name = "Access Control List",
    },

error:

Error: Invalid Attribute Value Match

  with sdwan_ipv4_acl_policy_definition.cn_qos_acl_marking,
  on sdwan-tf-import-main.tf line 12489, in resource "sdwan_ipv4_acl_policy_definition" "cn_qos_acl_marking":
12489: resource "sdwan_ipv4_acl_policy_definition" "cn_qos_acl_marking" {

Attribute sequences[2].match_entries[3].type value must be one of: ["dscp"
"sourceIp" "destinationIp" "class" "packetLength" "plp" "sourcePort"
"destinationPort" "sourceDataPrefixList" "destinationDataPrefixList"
"protocol" "tcp"], got: "icmpMessage"
@cmohorea
Copy link
Author

same for the sdwan_traffic_data_policy_definition

@seconroy seconroy self-assigned this Sep 2, 2024
@seconroy seconroy added the bug Something isn't working label Sep 2, 2024
seconroy added a commit to seconroy/terraform-provider-sdwan that referenced this issue Sep 2, 2024
@seconroy seconroy mentioned this issue Sep 5, 2024
8 tasks
danischm pushed a commit that referenced this issue Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants