From 2512a8bdc25990d70c4e2c2b1c1ee487d57007c6 Mon Sep 17 00:00:00 2001
From: Sampo Tawast <5328394+sirtawast@users.noreply.github.com>
Date: Thu, 22 Aug 2024 09:10:34 +0300
Subject: [PATCH] fix: loosen validation rules for new messages (#3222)

---
 backend/benefit/messages/serializers.py    | 6 +-----
 backend/benefit/messages/tests/test_api.py | 4 ++--
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/backend/benefit/messages/serializers.py b/backend/benefit/messages/serializers.py
index e4a0284dba..469096e17b 100644
--- a/backend/benefit/messages/serializers.py
+++ b/backend/benefit/messages/serializers.py
@@ -54,11 +54,7 @@ def validate(self, data):  # noqa: C901
             if company != application.company:
                 raise PermissionDenied(_("You are not allowed to do this action"))
 
-            if (
-                application.status not in self.APPLICANT_MESSAGE_ALLOWED_STATUSES
-                or application.batch
-                or application.archived
-            ):
+            if application.status not in self.APPLICANT_MESSAGE_ALLOWED_STATUSES:
                 raise serializers.ValidationError(
                     _(
                         "Cannot do this action because "
diff --git a/backend/benefit/messages/tests/test_api.py b/backend/benefit/messages/tests/test_api.py
index d284fe2e81..5cba2dadaa 100644
--- a/backend/benefit/messages/tests/test_api.py
+++ b/backend/benefit/messages/tests/test_api.py
@@ -245,8 +245,8 @@ def test_create_handler_message_invalid(handler_api_client, handling_application
         (ApplicationStatus.ADDITIONAL_INFORMATION_NEEDED, False, 201),
         (ApplicationStatus.ACCEPTED, False, 201),
         (ApplicationStatus.REJECTED, False, 201),
-        (ApplicationStatus.ACCEPTED, True, 400),
-        (ApplicationStatus.REJECTED, True, 400),
+        (ApplicationStatus.ACCEPTED, True, 201),
+        (ApplicationStatus.REJECTED, True, 201),
         (ApplicationStatus.CANCELLED, False, 400),
     ],
 )