From 8d344aae816669910b305f994be9d23b8b5ad7a5 Mon Sep 17 00:00:00 2001
From: Tero Virtanen <105207219+terovirtanen@users.noreply.github.com>
Date: Wed, 30 Aug 2023 07:13:36 +0300
Subject: [PATCH] build: tet review pipeline (#2189)

* chore: review pipeline DEVOPS-551
* chore: remove useless MockLoginView ja MockLogoutView from tet
---
 azure-pipelines/tet-review.yml | 65 ++++++++++++++++++++++++++++++++++
 backend/tet/tet/mock_views.py  | 42 ----------------------
 backend/tet/tet/urls.py        | 19 +---------
 3 files changed, 66 insertions(+), 60 deletions(-)
 create mode 100644 azure-pipelines/tet-review.yml
 delete mode 100644 backend/tet/tet/mock_views.py

diff --git a/azure-pipelines/tet-review.yml b/azure-pipelines/tet-review.yml
new file mode 100644
index 0000000000..10c1a3b119
--- /dev/null
+++ b/azure-pipelines/tet-review.yml
@@ -0,0 +1,65 @@
+#
+# Review pipeline. Run build and deploy for Platta test environments.
+# Pipeline runs different tests e.g. unittest and browser tests.
+#
+# Continuous integration (CI) triggers cause a pipeline to run whenever you push
+# an update to the specified branches or you push specified tags.
+# only PR trigger pipeline
+trigger: none
+
+# Pull request (PR) triggers cause a pipeline to run whenever a pull request is
+# opened with one of the specified target branches, or when updates are made to 
+# such a pull request.
+#
+# GitHub creates a new ref when a pull request is created. The ref points to a 
+# merge commit, which is the merged code between the source and target branches 
+# of the pull request.
+#
+# Opt out of pull request validation 
+pr:
+  # PR target branch
+  branches:
+    include:
+    - main
+  paths:
+    include:
+      - azure-pipelines/tet-review.yml
+      - backend/docker/tet.Dockerfile
+      - backend/tet/**
+      - backend/shared/**
+      - frontend/*
+      - frontend/tet/**
+      - frontend/shared/**
+    exclude:
+      - README.md
+      - backend/benefit/**
+      - backend/kesaseteli/**
+      - frontend/benefit/**
+      - frontend/kesaseteli/**
+      - frontend/**/browser-tests
+      - frontend/**/__tests__
+
+# By default, use self-hosted agents
+pool: Default
+
+resources:
+  repositories:
+  # Azure DevOps repository
+  - repository: yjdh-tet-pipelines
+    type: git
+    # Azure DevOps project/repository
+    name: yjdh-tet/yjdh-tet-pipelines
+
+extends:
+  # Filename in Azure DevOps Repository (note possible -ui or -api)
+  # Django example: azure-pipelines-PROJECTNAME-api-release.yml
+  # Drupal example: azure-pipelines-drupal-release.yml
+  template: azure-pipelines-tet-review.yml@yjdh-tet-pipelines
+    # Application build arguments and config map values as key value pairs.
+    # The values here will override the values defined in the yjdh-tet-pipelines repository.
+    # for example
+#  parameters:
+#    buildArgs:
+#      NEXT_PUBLIC_DEBUG: 0
+#    configMap: # pod environment variables
+#      DEBUG: 0
diff --git a/backend/tet/tet/mock_views.py b/backend/tet/tet/mock_views.py
deleted file mode 100644
index a50ae804a2..0000000000
--- a/backend/tet/tet/mock_views.py
+++ /dev/null
@@ -1,42 +0,0 @@
-from django.conf import settings
-from django.contrib import auth
-from django.http import HttpResponseRedirect
-from django.utils.decorators import method_decorator
-from django.views.decorators.csrf import ensure_csrf_cookie
-from django.views.generic import View
-
-from shared.common.tests.factories import StaffUserFactory
-
-
-class MockLogoutView(View):
-    """Mocked user logout"""
-
-    http_method_names = ["get", "post"]
-
-    def handle_logout(self, request):
-        if request.user.is_authenticated:
-            auth.logout(request)
-        return HttpResponseRedirect(settings.LOGOUT_REDIRECT_URL)
-
-    def get(self, request):
-        return self.handle_logout(request)
-
-    def post(self, request):
-        return self.handle_logout(request)
-
-
-class MockLoginView(View):
-    """Mocked user login"""
-
-    http_method_names = ["get"]
-
-    @method_decorator(ensure_csrf_cookie)
-    def get(self, request, *args, **kwargs):
-        if not request.user.is_authenticated:
-            user = StaffUserFactory()
-            auth.login(
-                request,
-                user,
-                backend="django.contrib.auth.backends.ModelBackend",
-            )
-        return HttpResponseRedirect(settings.LOGIN_REDIRECT_URL or "/")
diff --git a/backend/tet/tet/urls.py b/backend/tet/tet/urls.py
index a1f3dbe03b..a6bde4f6fe 100644
--- a/backend/tet/tet/urls.py
+++ b/backend/tet/tet/urls.py
@@ -22,24 +22,7 @@
     path("oidc/", include("shared.oidc.urls")),
 ]
 
-if not settings.NEXT_PUBLIC_MOCK_FLAG:
-    urlpatterns += [path("oauth2/", include("shared.azure_adfs.urls"))]
-else:
-    from tet.mock_views import MockLoginView, MockLogoutView
-
-    urlpatterns += [
-        path(
-            "oauth2/login",
-            MockLoginView.as_view(),
-            name="adfs_login",
-        ),
-        path(
-            "oauth2/logout",
-            MockLogoutView.as_view(),
-            name="adfs_logout",
-        ),
-    ]
-
+urlpatterns += [path("oauth2/", include("shared.azure_adfs.urls"))]
 
 if settings.ENABLE_ADMIN:
     urlpatterns.append(path("admin/", admin.site.urls))