From d510e2563017e7840e971c294a4214448ab38a0c Mon Sep 17 00:00:00 2001 From: Sampo Tawast Date: Tue, 22 Aug 2023 15:13:08 +0300 Subject: [PATCH] revert some serialization checks let's just do a custom endpoint to lock / unlock the application --- .../api/v1/serializers/application.py | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/backend/benefit/applications/api/v1/serializers/application.py b/backend/benefit/applications/api/v1/serializers/application.py index a4fc955ffd..ea922f1ebf 100755 --- a/backend/benefit/applications/api/v1/serializers/application.py +++ b/backend/benefit/applications/api/v1/serializers/application.py @@ -1078,26 +1078,6 @@ def _update_applicant_terms_approval(self, instance, approve_terms): if instance.application_origin == ApplicationOrigin.HANDLER: return - # Ignore updated applicant's terms if all term consents have been previously accepted - # This is "good enough" (confirmed this from City's benefit team) - if instance.applicant_terms_approval.selected_applicant_consents: - all_consents = sorted( - list( - instance.applicant_terms_approval.selected_applicant_consents.values_list( - "id" - ) - ) - ) - accepted_consents = sorted( - list( - instance.applicant_terms_approval.terms.applicant_consents.values_list( - "id" - ) - ) - ) - if accepted_consents == all_consents: - return - if not approve_terms: raise serializers.ValidationError( {"approve_terms": _("Terms must be approved")}