Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-lint CiviWiki JavaScript #46

Closed
6 tasks
brylie opened this issue Aug 30, 2017 · 4 comments
Closed
6 tasks

Auto-lint CiviWiki JavaScript #46

brylie opened this issue Aug 30, 2017 · 4 comments
Assignees
Milestone

Comments

@brylie
Copy link
Member

brylie commented Aug 30, 2017

As part of our commitment to clean and maintainable code, we can lint our JavaScript. Linting will catch low-level details and encourage common coding conventions between CiviWiki developers.

Goal

Enable automated linting on the CiviWiki project.

Task

  • Add ESLint metadata files to project root
  • Inherit from existing ESLint style, such as Airbnb ESLint rules
  • Override any of the Airbnb ESLint rules that we disagree with
  • Run a project-wide lint, to see the extent of the problem
  • Encourage CiviWiki developers to enable auto-linting in their IDE
  • Enable auto-linting for CiviWiki GitHub pull requests
@tractaylor
Copy link
Collaborator

Here is a link to adding ESLint to many editors. The same page has links on how to add github prehooks for projects.
https://eslint.org/docs/user-guide/integrations

@brylie brylie added this to the 0.2 milestone Nov 6, 2017
@delta-plus delta-plus self-assigned this Apr 3, 2018
@JOO33 JOO33 assigned JOO33 and unassigned delta-plus Jun 11, 2018
@brylie
Copy link
Member Author

brylie commented Nov 5, 2018

@JL24 can we separate this PR from your frontend refactor PR? That way we can close this issue sooner.

@brylie
Copy link
Member Author

brylie commented Dec 12, 2018

@JL24 if we don't have a status for this, should I go ahead and move it to 0.3 milestone?

@brylie brylie modified the milestones: 0.2, 0.3 Feb 8, 2019
@JOO33 JOO33 modified the milestones: 0.3, 2.0 Feb 24, 2021
@JOO33
Copy link
Member

JOO33 commented Feb 25, 2021

Closing due to solution proposed by #827. The JS related issues will be no longer relevant.

@JOO33 JOO33 closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants