Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: mix aio.Id with a generation number in Debug/Safe builds #44

Open
Cloudef opened this issue Jan 4, 2025 · 0 comments
Open

aio: mix aio.Id with a generation number in Debug/Safe builds #44

Cloudef opened this issue Jan 4, 2025 · 0 comments
Labels
enhancement New feature or request high-prio

Comments

@Cloudef
Copy link
Owner

Cloudef commented Jan 4, 2025

Avoid id reuse bugs and catch them early. Save days of head scratching and waste of time.
@Cloudef Cloudef added enhancement New feature or request high-prio labels Jan 4, 2025
Cloudef added a commit that referenced this issue Jan 4, 2025
@Cloudef
coro: remove io_ack from scheduler
90fb264 
The logic here is not sound and actually is the root cause for #31
The yield enough should be enough for valid io submission, in theory if
the task is cancelled immediately something weird could happen.. It is
better to implement #44 to make sure no such bug exists and are catch
early.

Fixes #31
Cloudef added a commit that referenced this issue Jan 4, 2025
@Cloudef
coro: remove io_ack from scheduler
420a0cc 
The logic here is not sound and actually is the root cause for #31
The yield enough should be enough for valid io submission, in theory if
the task is cancelled immediately something weird could happen.. It is
better to implement #44 to make sure no such bug exists and are catch
early.

Fixes #31
Cloudef added a commit that referenced this issue Jan 4, 2025
@Cloudef
coro: remove io_ack from scheduler
b4804be 
The logic here is not sound and actually is the root cause for #31
The yield enough should be enough for valid io submission, in theory if
the task is cancelled immediately something weird could happen.. It is
better to implement #44 to make sure no such bug exists and are catch
early.

Fixes #31
@Cloudef Cloudef changed the title aio: mix aio.Id with a generation number aio: mix aio.Id with a generation number in Debug/Safe builds Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request high-prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cloudef