Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Sonic's mappings from the old Hivebrain Disassembly #1

Open
SameytheHedgehog opened this issue May 20, 2023 · 2 comments

Comments

@SameytheHedgehog
Copy link

ClownMapEd can't load this while SonMapEd can:

; ---------------------------------------------------------------------------
; Sprite mappings - Sonic
; ---------------------------------------------------------------------------
		dc.w byte_21293-Map_Sonic
byte_21293:	dc.b 4			; standing
		dc.b $EC, 8, 0,	0, $F0
		dc.b $F4, $D, 0, 3, $F0
		dc.b 4,	8, 0, $B, $F0
		dc.b $C, 8, 0, $E, $F8
		even

SonMapEd seems to completely ignore if Map_Sonic: is missing while ClownMapEd requires it, stating "file could not be assembled" if attempting to load the above.

@Clownacy
Copy link
Owner

This is also a problem with the Sonic & Knuckles Git disassembly.

According to this, SonMapEd uses a partial 68k assembly parser which only implements the bare minimum needed to load mappings. I imagine that it ignores the label to the right of the '-' character, which explains why the lack of a definition for that label does not result in an error.

ClownMapEd uses a proper assembler, so it does not ignore the missing label.

I do have one idea for solving this issue: manually parse the very start of the file to determine the missing label, and then create a copy of the file with that label inserted at the beginning. ClownMapEd can then load that without error.

Until this is fixed, users will have to manually add the missing labels to their mappings themselves.

@Brainulator9
Copy link

This is also a problem with the Sonic & Knuckles Git disassembly.

I want to note that sonicretro/skdisasm@39723e7 corrects this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants