Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clued-In checks script not properly evaluating docker-compose #18

Open
stegs opened this issue Sep 27, 2022 · 1 comment
Open

Clued-In checks script not properly evaluating docker-compose #18

stegs opened this issue Sep 27, 2022 · 1 comment

Comments

@stegs
Copy link

stegs commented Sep 27, 2022

Hello,

The script checks.ps1 is only evaluating as successful if the major version > 1 AND minor version > 26. However, I am currently running 2.10.2. So my major version > 1 but my minor version < 26. I have a later version of docker-compose and the script can't recognize it.

    [Check]::new('Docker Compose', {
        $info = docker-compose version --short
        $major,$minor,$patch = $info.Trim().Split('.')
        **$success = ($major -ge 1) -and ($minor -ge 26)**
        [CheckResult]::new($success, $info)
    },

Thanks.

@aleksandarkovacevic30
Copy link

Hey, just wanted to mention this as well. It makes this step fail even though it is correct 2.12.2 > 1.26.0 , but the logic fails on minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants