Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose install instructions are out of date [was: Compose install instructions don't work if you've installed Flocker] #23

Open
lukemarsden opened this issue Jul 5, 2015 · 3 comments

Comments

@lukemarsden
Copy link
Contributor

Following the instructions here: https://docs.clusterhq.com/en/1.0.1/labs/compose.html

We are told to run:

$ sudo pip install git+https://github.com/lukemarsden/compose.git@volume_driver

However, because Flocker is already installed on these nodes, and because docker-py is a dep of flocker, docker-py is already installed too. And so, perhaps due to version number incongruity, the custom version of docker-py does not get pulled down (I think).

Manually running:

$ sudo pip install --upgrade git+https://github.com/lukemarsden/docker-py.git@e2ba8a54935df8d40676529f67b16f5927e51000#egg=docker-py
$ sudo pip install 'requests>=2.6.1,<2.7'

Resolves this issue.

@lukemarsden
Copy link
Contributor Author

@binocarlos I saw this in manual testing, would you mind testing to confirm the issue exists?

WDYT about fixing this? We could just wait for a compose release that includes volume_driver support, although maybe adding a note to the docs in the meantime would help.

Or maybe we could declare a tighter dependency in https://github.com/lukemarsden/compose/tree/volume_driver somehow.

@binocarlos
Copy link
Contributor

@lukemarsden Can confirm that this issue exists having tested it manually - once I had done the manual pip install step it did not complain about missing 'volume-driver' any more.

I'm not sure how we can specify a tighter dependency than a git commit hash?

I will put a note in the labs docs about these extra 2 steps I think that is the best plan until the change is merged into master.

@lukemarsden
Copy link
Contributor Author

we should update the compose docs to refer to the fact that mainline compose supports volume_driver now.

@lukemarsden lukemarsden changed the title Compose install instructions don't work if you've installed Flocker Compose install instructions are out of date [was: Compose install instructions don't work if you've installed Flocker] Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants