Skip to content
This repository has been archived by the owner on May 29, 2022. It is now read-only.

TPS drop #411

Open
2 tasks done
Fejm opened this issue May 12, 2022 · 13 comments
Open
2 tasks done

TPS drop #411

Fejm opened this issue May 12, 2022 · 13 comments
Labels
bug Something isn't working

Comments

@Fejm
Copy link

Fejm commented May 12, 2022

Observed Behavior

TPS drops even on empty server to ~19.25

[21:58:43 INFO]: TPS from last 1m, 5m, 15m: 19.75, 19.75, 19.91
No players, no plugins, clean test server, new world, no CPU usage at all (Ryzen 7 3800X), 4GB RAM allocated, JAVA 17

Expected Behavior

TPS = ~19.99

Steps To Reproduce

Just start server, without plugins..

Plugin List

none

Server Version

[21:52:58 INFO]: Checking version, please wait...
[21:52:59 INFO]: This server is running NachoSpigot version git-NachoSpigot-74ed0ea (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)
You are running the latest version

Other

No response

Agreements

  • You were able to find this issue on the latest version of NachoSpigot.
  • You have confirmed that there aren’t any issues open regarding this bug.
@Fejm Fejm added the bug Something isn't working label May 12, 2022
@windcolor-dev
Copy link

I believe the server tps is actually stable, the latest Paper uses BigDecimals to calculate tps which is more accurate than the current system. After updating Paper's tick loop improvement patch, the tps display will probably be more accurate.

@Fejm
Copy link
Author

Fejm commented May 14, 2022

I tried to update this patch, no change at all in tps display.
Adding debug sysout in loop shows that server is ticking 51 - 52 ms, ofc server is trying to catch up at 49ms but it's not too much.. So actually tps display is correct - there is no 20 tps.

To be honest, server is not lagging, you can modify max tps and server will tick higher without any problem. There is problem in Thread.sleep calc, server is waiting too long and its unable to catchup.

@ytnoos
Copy link
Contributor

ytnoos commented May 14, 2022

I tried to update this patch, no change at all in tps display.

Adding debug sysout in loop shows that server is ticking 51 - 52 ms, ofc server is trying to catch up at 49ms but it's not too much.. So actually tps display is correct - there is no 20 tps.

To be honest, server is not lagging, you can modify max tps and server will tick higher without any problem. There is problem in Thread.sleep calc, server is waiting too long and its unable to catchup.

Are you testing this on Windows?

@Fejm
Copy link
Author

Fejm commented May 14, 2022

I tried to update this patch, no change at all in tps display.
Adding debug sysout in loop shows that server is ticking 51 - 52 ms, ofc server is trying to catch up at 49ms but it's not too much.. So actually tps display is correct - there is no 20 tps.
To be honest, server is not lagging, you can modify max tps and server will tick higher without any problem. There is problem in Thread.sleep calc, server is waiting too long and its unable to catchup.

Are you testing this on Windows?

On Windows 11 and Debian 11. Same issue.

@windcolor-dev
Copy link

hmm that's weird, on my fork I updated the patch and tps ranges from 19.99-20 whilst idling

@Fejm
Copy link
Author

Fejm commented May 14, 2022

hmm that's weird, on my fork I updated the patch and tps ranges from 19.99-20 whilst idling

Can i look on your patch?

@windcolor-dev
Copy link

windcolor-dev commented May 14, 2022

Yeah, here are my changes: https://github.com/Wind-Development/WindSpigot/pull/21/files

@Fejm
Copy link
Author

Fejm commented May 14, 2022

Well, this is exactly what I did myself.
What CPU you are using? Intel?

@windcolor-dev
Copy link

I've checked tps on servers running on the Intel i5-9300H and an arm cpu from oracle cloud. Servers' tps on the oracle cloud instance drops to 19.97 at times, but there are like 5 servers running on the same instance.

@HowardZHY
Copy link

timings?

@ghost
Copy link

ghost commented May 16, 2022

try to use Java 11 or 8

@Fejm
Copy link
Author

Fejm commented May 18, 2022

try to use Java 11 or 8

Tested on 8, 11 and 17. Same results.

@HowardZHY
Copy link

HowardZHY commented May 18, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants