Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide links to content #175

Open
techieshark opened this issue May 16, 2016 · 2 comments
Open

provide links to content #175

techieshark opened this issue May 16, 2016 · 2 comments

Comments

@techieshark
Copy link
Contributor

Currently when you search for a school (either by name or your address), you'll get to the content but the site's URL doesn't change, meaning you can't link directly to that thing (like a permalink).

Either users don't care about this, or we haven't done enough testing in real world situations to have this issue come up (note that I'm reporting this, not any user or based on conversations with users).

If we wanted to address this, we could use the History API to make the site's URL change and reflect the content being viewed.

Implementation questions include:

  • If a user types their address, do we include their address in the URL of the result?
  • If a user searches for a school by name but then selects another school using the map, should the URL reflect what they originally searched for or the current state of the view?

Related:

Issue #118
http://neugierig.org/software/blog/2014/02/single-page-app-links.html
https://medium.com/@stilkov/why-i-hate-your-single-page-app-f08bb4ff9134#.fh7gkqs1v
https://www.shiftedup.com/2014/10/15/is-a-single-page-application-what-you-really-need

@techieshark
Copy link
Contributor Author

@Rustuma @reekypete @kate-miller have you come across any need to link to specific schools yet? Is that why the ?school_code=xxxx was added?

@Rustuma
Copy link
Collaborator

Rustuma commented Aug 1, 2016

I don't know. @reekypete ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants