From 60f368054e30f098976bef9be035f569a8fb554c Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Wed, 28 Feb 2024 15:44:50 +0200 Subject: [PATCH 1/4] fix: prevent jobs from stopping the cron loop --- includes/admin/feedzy-rss-feeds-import.php | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/includes/admin/feedzy-rss-feeds-import.php b/includes/admin/feedzy-rss-feeds-import.php index 8d63c40b..cbb5d579 100644 --- a/includes/admin/feedzy-rss-feeds-import.php +++ b/includes/admin/feedzy-rss-feeds-import.php @@ -1187,13 +1187,20 @@ public function run_cron( $max = 100 ) { 'post_status' => 'publish', 'numberposts' => 99, ); + $feedzy_imports = get_posts( $args ); foreach ( $feedzy_imports as $job ) { - $result = $this->run_job( $job, $max ); - if ( empty( $result ) ) { - $this->run_job( $job, $max ); + try { + $result = $this->run_job( $job, $max ); + if ( empty( $result ) ) { + $this->run_job( $job, $max ); + } + do_action( 'feedzy_run_cron_extra', $job ); + } catch ( Exception $e ) { + if ( defined( 'WP_DEBUG' ) && WP_DEBUG ) { + error_log( '[Feedzy Run Cron][Post title: ' . ( ! empty( $job->post_title ) ? $job->post_title : '' ) . '] Error: ' . $e->getMessage() ); + } } - do_action( 'feedzy_run_cron_extra', $job ); } } From 92855c50dd911c4ff33c1637df49b311ae6919f9 Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Mon, 4 Mar 2024 11:27:47 +0200 Subject: [PATCH 2/4] fix: pro feature img fetch crash free users on Cron --- includes/admin/feedzy-rss-feeds-import.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/admin/feedzy-rss-feeds-import.php b/includes/admin/feedzy-rss-feeds-import.php index cbb5d579..402d5a12 100644 --- a/includes/admin/feedzy-rss-feeds-import.php +++ b/includes/admin/feedzy-rss-feeds-import.php @@ -1782,7 +1782,7 @@ function( $term ) { } // Fetch image from graby. - if ( empty( $image_url ) && ( wp_doing_cron() || defined( 'FEEDZY_PRO_FETCH_ITEM_IMG_URL' ) ) ) { + if ( empty( $image_url ) && ( wp_doing_cron() && defined( 'FEEDZY_PRO_FETCH_ITEM_IMG_URL' ) ) ) { // if license does not exist, use the site url // this should obviously never happen unless on dev instances. $license = apply_filters( 'product_feedzy_license_key', sprintf( 'n/a - %s', get_site_url() ) ); From a7ec5e05455eebc7f3b634fd1743cfd638a0bdc1 Mon Sep 17 00:00:00 2001 From: "Soare Robert Daniel (Mac 2023)" Date: Thu, 7 Mar 2024 09:56:54 +0200 Subject: [PATCH 3/4] fix: css name conflict for `.right` class name --- css/metabox-settings.css | 16 ++--- css/settings.css | 19 +++--- includes/layouts/feedzy-improve.php | 4 +- includes/views/import-metabox-edit.php | 84 +++++++++++++------------- 4 files changed, 62 insertions(+), 61 deletions(-) diff --git a/css/metabox-settings.css b/css/metabox-settings.css index dfec6926..fae7c4c5 100644 --- a/css/metabox-settings.css +++ b/css/metabox-settings.css @@ -42,16 +42,16 @@ .fz-input-group{flex-wrap: wrap;} .fz-input-group .fz-input-group-right{width: 100%; padding-left: 0; padding-top: 8px;} .fz-input-group .fz-input-group-right .btn.dropdown-toggle{width: 100%;} - .fz-form-wrap .form-block.form-block-two-column .left{width: 100%; padding-right: 0; padding-bottom: 24px;} - .fz-form-wrap .form-block.form-block-two-column .right{width: 100%;} - .fz-form-action .left{width: 100%; padding-bottom: 16px;} - .fz-form-action .left .btn{width: 100%; display: block; text-align: center;} - .fz-form-action .right{width: 100%; flex-direction: column;} - .fz-form-action .right .btn + .btn{margin-left: 0; margin-top: 8px;} + .fz-form-wrap .form-block.form-block-two-column .fz-left{width: 100%; padding-right: 0; padding-bottom: 24px;} + .fz-form-wrap .form-block.form-block-two-column .fz-right{width: 100%;} + .fz-form-action .fz-left{width: 100%; padding-bottom: 16px;} + .fz-form-action .fz-left .btn{width: 100%; display: block; text-align: center;} + .fz-form-action .fz-right{width: 100%; flex-direction: column;} + .fz-form-action .fz-right .btn + .btn{margin-left: 0; margin-top: 8px;} .fz-form-row .fz-form-col-6, .fz-form-row .fz-form-col-4, .fz-form-row .fz-form-col-8{width: 100%;} .fz-document-list > ul > li{width: 100%;} - .fz-help-improve-box .left{width: 100%;} - .fz-help-improve-box .right{width: 100%;} + .fz-help-improve-box .fz-left{width: 100%;} + .fz-help-improve-box .fz-right{width: 100%;} .fz-tabs-menu ul {flex-wrap: wrap;} .fz-tabs-menu ul li{flex-shrink: 0; width: 50%;} .fz-tabs-menu ul li a{padding: 0px; border: 1px solid transparent;} diff --git a/css/settings.css b/css/settings.css index 15c775ee..b5e637c1 100644 --- a/css/settings.css +++ b/css/settings.css @@ -350,14 +350,15 @@ fieldset[disabled] .form-control { display: flex; flex-wrap: wrap; } -.fz-form-wrap .form-block.form-block-two-column .left{ +.fz-form-wrap .form-block.form-block-two-column .fz-left{ width: 285px; padding-right: 24px; } -.fz-form-wrap .form-block.form-block-two-column .right{ +.fz-form-wrap .form-block.form-block-two-column .fz-right{ width: calc(100% - 285px); + text-align: left; } -.fz-form-wrap .form-block.form-block-two-column .right .upgrade-alert{ +.fz-form-wrap .form-block.form-block-two-column .fz-right .upgrade-alert{ margin-top: 20px; } .fz-form-wrap .form-block .only-pro-content{ @@ -666,14 +667,14 @@ input.fz-switch-toggle[type=checkbox]:checked:before{ flex-wrap: wrap; justify-content: space-between; } -.fz-form-action .right{ +.fz-form-action .fz-right{ display: flex; flex-wrap: wrap; } -.fz-form-action .right .btn{ +.fz-form-action .fz-right .btn{ margin-bottom: 8px; } -.fz-form-action .right .btn + .btn{ +.fz-form-action .fz-right .btn + .btn{ margin-left: 16px; } @@ -1310,18 +1311,18 @@ input.fz-switch-toggle[type=checkbox]:checked:before{ flex-direction: row-reverse; border: 1px solid #D9D9D9; } -.fz-help-improve-box .left{ +.fz-help-improve-box .fz-left{ width: calc(100% - 320px); padding: 30px; } -.fz-help-improve-box .left p{ +.fz-help-improve-box .fz-left p{ font-size: 16px; line-height: 24px; color: #050505; margin-bottom: 24px; max-width: 710px; } -.fz-help-improve-box .right{ +.fz-help-improve-box .fz-right{ width: 320px; padding: 18px; background-color: #F5F7F9; diff --git a/includes/layouts/feedzy-improve.php b/includes/layouts/feedzy-improve.php index f90a4cf2..97468f48 100644 --- a/includes/layouts/feedzy-improve.php +++ b/includes/layouts/feedzy-improve.php @@ -1,10 +1,10 @@
-
+
-
+

Answer a few questions to help us improve Feedzy

We're always looking for suggestions to further improve Feedzy. diff --git a/includes/views/import-metabox-edit.php b/includes/views/import-metabox-edit.php index 03d3d8fb..ecf69cc4 100644 --- a/includes/views/import-metabox-edit.php +++ b/includes/views/import-metabox-edit.php @@ -126,7 +126,7 @@ class="dashicons dashicons-arrow-down-alt2">

-
+

PRO' : ''; ?>

-
+
@@ -180,10 +180,10 @@ class="dashicons dashicons-arrow-down-alt2">
-
+

PRO' : ''; ?>

-
+
@@ -223,10 +223,10 @@ class="dashicons dashicons-arrow-down-alt2">
-
+

PRO' : ''; ?>

-
+