Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some feeds appear as invalid in Feedzy while they are valid #880

Closed
vytisbulkevicius opened this issue Feb 5, 2024 · 3 comments · Fixed by #885 or #888
Closed

Some feeds appear as invalid in Feedzy while they are valid #880

vytisbulkevicius opened this issue Feb 5, 2024 · 3 comments · Fixed by #885 or #888
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. tiny (1h) - This label is used for issues that can be completed in under an hour.

Comments

@vytisbulkevicius
Copy link
Contributor

Description

These feeds show up as invalid if you try to save them in Feedzy import:
https://www.osha.gov/laws-regs/federalregisters.xml
https://www.usnews.com/rss/the-report

image

These feeds are valid from what I see, they can be checked on SimplePie as well:
https://simplepie.org/demo/?feed=https%3A%2F%2Fwww.usnews.com%2Frss%2Fthe-report
https://simplepie.org/demo/?feed=https%3A%2F%2Fwww.osha.gov%2Flaws-regs%2Ffederalregisters.xml

Step-by-step reproduction instructions

  1. Try to create a new import and use the feeds I shared above.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

@vytisbulkevicius vytisbulkevicius added bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. labels Feb 5, 2024
@tio-trom
Copy link

tio-trom commented Feb 5, 2024

I have reported it here https://wordpress.org/support/topic/this-source-has-invalid-urls/#post-17399998 about similar issues for me.

The following fail for me:

https://www.tromjaro.com/category/apps/feed
https://forum.tromjaro.com/c/releases.rss
https://privacyinternational.org/rss.xml
https://newsrss.bbc.co.uk/rss/newsonline_uk_edition/sci/tech/rss.xml
https://www.directory.trade-free.org/category/goods-services/feed
https://www.tiotrom.com/feed

2024-02-05_22-35

@Soare-Robert-Daniel
Copy link
Contributor

Soare-Robert-Daniel commented Feb 6, 2024

@vytisbulkevicius, this one is pretty weird. I spent some time debugging the plugin and found no issue.

The actual issue is the WordPress SimplePie lib. Not all websites are reachable to it. So, the error was given.

Problematic links:

To ensure we are not just unlucky, I checked with other plugins and got the same result: the WP lib can not fetch the data.

rss-feed-fail-1

rss-feed-fail-2

Since the plugin invalidates the whole process, working URLs like https://www.tiotrom.com/feed are also reported as invalid.

ℹ️ I suspect that those problematic links might have a filter blocking WordPress access. It might be a protection anti-bot.


One improvement we can make regarding this issue is to display better errors to highlight non-working links better.

@vytisbulkevicius
Copy link
Contributor Author

Thank you for the investigation @Soare-Robert-Daniel.

I see other plugins don't have a more specific error message but it would make sense to modify the message.

In New Import:

From:

This source has invalid URLs. Please correct/remove the following:

To:

This source has invalid or unreachable by WordPress SimplePie URLs. Please correct/remove the following:

In block usage:

From:

Feed URL is invalid. Invalid feeds will NOT display items.

To:

Feed URL is invalid or unreachable by WordPress SimplePie and will NOT display items.

When creating a category:

From:

We found the following invalid URLs that we have removed from the list:

To:

We found the following invalid or unreachable by WordPress SimplePie URLs that we have removed from the list:

IMO, it's irritating when you try to save it and only get information that the feed is invalid while you know it's valid.

@Soare-Robert-Daniel Soare-Robert-Daniel added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Feb 9, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Feb 9, 2024 that will close this issue
@vytisbulkevicius vytisbulkevicius linked a pull request Feb 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. Priority-Medium Expected resolution time - up to 1 month. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
3 participants