Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination issue for archive pages #105

Closed
irinelenache opened this issue Jan 12, 2024 · 3 comments
Closed

Pagination issue for archive pages #105

irinelenache opened this issue Jan 12, 2024 · 3 comments
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Milestone

Comments

@irinelenache
Copy link
Contributor

Description

In Neve FSE, the pagination is not added by default in the Archives template. When i manually add it and have a large number of posts (100 in my example), only the first 3 pages will be accessible in frontend (in editor it looks fine). Accessing other pages can be done only by changing the page number in the URL directly

(I checked and the pagination works fine in Raft and the default wp themes)

Reported here - https://wordpress.org/support/topic/default-wordpress-pagination-buttons-broken/

Step-by-step reproduction instructions

  1. Install Neve FSE
  2. Add the pagination block in the archives template
  3. Install FakerPress and generate a large number of posts (so more pages will be available)
  4. Check how the pagination works on an archive page

Screenshots, screen recording, code snippet or Help Scout ticket

https://vertis.d.pr/i/g12AvM
https://wordpress.org/support/topic/default-wordpress-pagination-buttons-broken/

Environment info

WordPress 6.4.2 / Neve FSE 1.0.6

Is the issue you are reporting a regression

No

@irinelenache irinelenache added bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. labels Jan 12, 2024
@JohnPixle JohnPixle added this to the 1.0.7 milestone Jan 15, 2024
@JohnPixle
Copy link
Contributor

Thanks for reporting and for providing the context here Irinel! I will take a look and schedule a fix 👍🏻

@JohnPixle
Copy link
Contributor

@HardeepAsrani Looks like there is an issue here with the pagination indeed. I just tested it on an instance, and the pagination always displays just a few page numbers.

Instance Magic Login

The pagination is missing on the All Archives template.

But even at the Index template, with the existing pagination, we get the same behaviour. The blog has now about 40 posts, with the number of posts per page set to 6 (reading settings).

My suggestion is to take a look into it, and add the pagination code in the index page. I can help with the second one.

Thanks!

@HardeepAsrani HardeepAsrani self-assigned this Feb 5, 2024
@HardeepAsrani HardeepAsrani added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Feb 5, 2024
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

No branches or pull requests

4 participants