Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding changed from 1.0.6 to version: 1.0.7 #115

Closed
iDschepe opened this issue Feb 27, 2024 · 2 comments
Closed

Padding changed from 1.0.6 to version: 1.0.7 #115

iDschepe opened this issue Feb 27, 2024 · 2 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product. regression Issue represents a change in behavior from a previous version that is not intended or desired..

Comments

@iDschepe
Copy link

Description

Hi there,

After updating the theme to 1.0.7 the padding seemed to changed for some footer blocks and also for my cover block at the landing page. In my example, you can see the padding of the whole site content.

Step-by-step reproduction instructions

Update to 1.0.7 - full site content has padding applied.

Screenshots, screen recording, code snippet or Help Scout ticket

error-spacing

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

@iDschepe iDschepe added the bug This label could be used to identify issues that are caused by a defect in the product. label Feb 27, 2024
@pirate-bot pirate-bot added the regression Issue represents a change in behavior from a previous version that is not intended or desired.. label Feb 27, 2024
@JohnPixle
Copy link
Contributor

Hey there @iDschepe ! thanks for taking the time to create the issue.
I cannot replicate this with the current version, I just tested it on a fresh site and the padding works as I expected, but I am happy to look further into your it.

Indeed in the last version, we made some adjustments to the padding in order to address a problem, but those adjustments should not have reproduced the results I see in your screenshot. However it might be possible that this has affected your layout in some other way, especially if you have already been making padding adjustments on your page or globally.

From what I see in the screenshot it looks like the whole page container got extra padding all around. It might be possible that you can fix this globally, from your site settings and edit the template for the page.

If you need further assistance, I am happy to help, but better to handle it as a support request so I can take a deeper look at your site. Let me know how this sounds.

Thanks again!

@iDschepe
Copy link
Author

iDschepe commented Mar 6, 2024

Hi @JohnPixle thank you, I will open a support request.

@iDschepe iDschepe closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. regression Issue represents a change in behavior from a previous version that is not intended or desired..
Projects
None yet
Development

No branches or pull requests

3 participants