Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks added in the footer lose styling when Elementor is activated #4150

Closed
irinelenache opened this issue Nov 22, 2023 · 5 comments · Fixed by Codeinwp/otter-blocks#1979
Closed
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less.

Comments

@irinelenache
Copy link
Contributor

Description

Blocks added as footer widgets lose their styling when i activate Elementor. The issue happens with core blocks everytime and sometimes with Otter blocks. https://vertis.d.pr/v/xVQM62

Step-by-step reproduction instructions

  1. Add some blocks in the footer widget area and set some styling to them
  2. Activate Elementor and check if the blocks look the same

Screenshots, screen recording, code snippet or Help Scout ticket

https://vertis.d.pr/v/xVQM62

Environment info

WordPress 6.4.1 / PHP 8.0 / Neve 3.7.3 / Elementor 3.17.3

Is the issue you are reporting a regression

Yes, this is a regression.

@irinelenache irinelenache added the bug This label could be used to identify issues that are caused by a defect in the product. label Nov 22, 2023
@pirate-bot pirate-bot added the regression Issue represents a change in behavior from a previous version that is not intended or desired.. label Nov 22, 2023
@preda-bogdan
Copy link
Contributor

@irinelenache can you provide me with some more details on how to replicate this, I tried adding some blocks to the footer widget and activating Elementor on WP6.4.1 and nothing happened with the styles. One issue that I do see is that some blocks do not render on the front end regardless if Elementor is present or not.

Let me know and I can further investigate and fix this issue. Thank you!

@preda-bogdan preda-bogdan added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Nov 23, 2023
@irinelenache
Copy link
Contributor Author

@preda-bogdan I tried to dig more into this and i see that the issue is happening with Otter blocks when the blocks are added/edited directly from the customizer, you can see a video here https://vertis.d.pr/v/LPQQeN .

You can check on this instance:

 Admin area URL: https://decideday.s2-tastewp.com/wp-admin 
 Username: irinel 
 Password: z2O1bWudFds 

preda-bogdan added a commit to Codeinwp/otter-blocks that referenced this issue Nov 27, 2023
@preda-bogdan
Copy link
Contributor

preda-bogdan commented Nov 27, 2023

@irinelenache Can you check if the linked PR from Otter will solve the issue?
Thank you!

Note

We can remove the regression label from here if the PR from Otter fixes this issue, as it does not stem from Neve.

@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Nov 27, 2023 that will close this issue
9 tasks
@preda-bogdan preda-bogdan removed the regression Issue represents a change in behavior from a previous version that is not intended or desired.. label Nov 28, 2023
@preda-bogdan
Copy link
Contributor

I've removed the regression label from here as this is not related to Neve and it is an issue with Otter and how it handles blocks inside the widgets section.

@HardeepAsrani
Copy link
Member

@preda-bogdan This was released part of the latest Otter release. You can close it nothing else is needed to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants