Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTML5 script tags #4167

Closed
irinelenache opened this issue Dec 7, 2023 · 1 comment · Fixed by #4168
Closed

Add support for HTML5 script tags #4167

irinelenache opened this issue Dec 7, 2023 · 1 comment · Fixed by #4168
Assignees
@Soare-Robert-Daniel
Labels
3rd-part-compatibilities Issue or feature related to a compatibility with a 3rd party product. customer report Indicates the request came from a customer. new feature Request for a new feature or functionality to be added to the project. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@irinelenache
Copy link
Contributor

What problem does this address?

We should add support for HTML5 tags to ensure compatibility with some plugins like WordPress Popular Posts. In the latest release they added a workaround for it, but the plugin developer said it would be ideal if we provided support for HTML5 script tags

Mentioned here - https://wordpress.org/support/topic/html5-support-5/#post-17235418

What is your proposed solution?

/**
 * Adds support for HTML5 script tags
 */
add_theme_support( 'html5', array('script') );

Will this feature require documentation? (Optional)

No.
@irinelenache irinelenache added 3rd-part-compatibilities Issue or feature related to a compatibility with a 3rd party product. new feature Request for a new feature or functionality to be added to the project. customer report Indicates the request came from a customer. labels Dec 7, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Dec 7, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Dec 7, 2023
Merged
6 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Dec 7, 2023 that will close this issue
Enable full HTML5 theme support #4168
Merged
6 tasks
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
3rd-part-compatibilities Issue or feature related to a compatibility with a 3rd party product. customer report Indicates the request came from a customer. new feature Request for a new feature or functionality to be added to the project. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable full HTML5 theme support Codeinwp/neve
4 participants
@Soare-Robert-Daniel @vytisbulkevicius @pirate-bot @irinelenache