Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra column when editing Line chart with simple editor #1174

Closed
Mara42 opened this issue Jul 26, 2024 · 5 comments · Fixed by #1200 or #1205
Closed

Extra column when editing Line chart with simple editor #1174

Mara42 opened this issue Jul 26, 2024 · 5 comments · Fixed by #1200 or #1205
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@Mara42
Copy link

Mara42 commented Jul 26, 2024

Description

When editing/creating a Line chart and editing its data with Simple editor, if you change the name of the last columns (all of them or just one but not the first one; if you change the name of the first column the plugin will work as it should), and then click Show Chart, an extra column will appear (the one that actually was renamed in the previous step if we renamed one, or the last one we renamed if multiple columns were modified). And if we go back and try to edit it with the simple editor there is no way to see this additional column (even though it is displayed in the chart legend).

Step-by-step reproduction instructions

  1. Make sure to have Visualizer installed and start to edit/add a page
  2. Click on plus and Select Visualizer Chart
  3. Select Create New Chart and select Line Chart
  4. Select Simple Editor and click on Edit Data
  5. Rename the last columns (you can rename any column except the first one to see this behaviour)
  6. Click on Show Chart

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot 2024-07-26 at 11 04 52

Rename one of the last columns:
Screenshot 2024-07-26 at 11 05 01

Screenshot 2024-07-26 at 11 08 52

Extra column showing
Screenshot 2024-07-26 at 11 05 10

Click on edit and the column is not there
Screenshot 2024-07-26 at 11 05 21

Environment info

https://pastebin.com/wS1tsBvP

Is the issue you are reporting a regression

No

@Mara42 Mara42 added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 26, 2024
@girishpanchal30 girishpanchal30 linked a pull request Dec 2, 2024 that will close this issue
6 tasks
@girishpanchal30
Copy link
Contributor

I've reviewed this issue and fixed it here - #1200

@poonam279
Copy link

@girishpanchal30 I have tested the PR, and it fixes the issue on a new instance.

However, it still shows the issue where we have already faced the issue. Here is the site where I first created this issue, and it's still showing the same issue. The new charts, which were created after installing the build, are also displaying the same problem.

Admin area URL: https://implementcats.s2-tastewp.com/wp-admin
Username: poonam
Password: eEEEVjkcEW0

@girishpanchal30
Copy link
Contributor

@poonam279

However, it still shows the issue where we have already faced the issue. Here is the site where I first created this issue, and it's still showing the same issue.

The issue is related to JavaScript, so it will only work with newly created charts.

The new charts, which were created after installing the build, are also displaying the same problem.

I have created a new chart in your test instance, and it appears to be working fine for me.

Image

@poonam279
Copy link

Thanks @girishpanchal30, I created and edited the line chart before installing the build, and that's why the line chart is still showing the issue. Can you try the same?

Image

@girishpanchal30
Copy link
Contributor

@poonam279 Changes will not be applied automatically to the existing chart. You need to either recreate the chart or edit the chart data.
This issue is related to the JavaScript code, and the changes are not applied automatically to the existing chart.

Thanks

@vytisbulkevicius vytisbulkevicius linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants