Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping glyphs #124

Open
xfq opened this issue Aug 29, 2023 · 3 comments
Open

Overlapping glyphs #124

xfq opened this issue Aug 29, 2023 · 3 comments

Comments

@xfq
Copy link

xfq commented Aug 29, 2023

The Han characters look like overlapping of several different glyphs of the same code point. If I open the SVG, I can see the animation, but not on the character page (example). Is it possible to animate it, or display a default glyph and let the user switch to other glyphs if they want? Thank you!

@Boldewyn
Copy link
Contributor

Thanks for noticing and opening the issue!

Yes, that is an unfortunate issue. Long story short, the images for CJK characters are effectively and deliberately an overlay of the HK, JP, KR, SC and TC glyphs and should animate from one to the other via SVG animations.

This works perfectly well, when you look at the SVGs directly, and it used to work in Firefox with embedded SVGs, when I developed the feature. Since then, however, did not only the other engines not start supporting this, but Firefox even regressed and involuntarily removed the feature again: https://bugzilla.mozilla.org/show_bug.cgi?id=1779834

I don’t want to miss this feature of showing the visitors the variety of glyphs behind the CJK unification, but I need to find a solution how to re-activate the animations again.

@Boldewyn
Copy link
Contributor

I’m currently experimenting with copying the glyphs from the <use> element directly into the DOM. However I need to do that performantly without re-requesting all the images, especially on list pages.

@Boldewyn
Copy link
Contributor

Boldewyn commented May 22, 2024

This issue is partly fixed for the glyphs on the detail pages, where I include them directly into the page HTML. But we’ve got more work to do here:

  • glyphs on list pages
  • small glyphs in cross-cp links
  • disable animation for users with prefers reduced motion setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants